No Code Attached Yet Frontend Template bug
avatar brianteeman
brianteeman
17 Jul 2024

Cassiopeia Colours

The cassiopeia template ships with two colour themes

  • build\media_source\templates\site\cassiopeia\scss\global\colors_alternative.scss
  • build\media_source\templates\site\cassiopeia\scss\global\colors_standard.scss

I can't determine exactly why they were created in this way but I would assume that the variables in these schemes would be sufficient to completely override the bootstrap colours.

However that this not the case as they only change some parts but not all.

An easy example is to look at a primary button when using the alternative colour theme where it is clear that the active state is not correct.

Normal

image

Hover

image

Active

image

Moving Forward

My non-css expert eye says that we are setting the variables wrong and instead of creating --cassiopeia-* variables we should be using the Bootstrap color system (https://getbootstrap.com/docs/5.3/customize/color/) - maybe we are not using that as that is newer to bootstrap than when cassiopeia was created.

Is this something we should address now - or would it be considered to be a b/c break that would have to wait for Joomla 6 where we can completely re-assess the way that we are customising bootstrap?

avatar brianteeman brianteeman - open - 17 Jul 2024
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2024
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 17 Jul 2024
avatar chmst chmst - change - 17 Jul 2024
Labels Added: Feature Frontend Template
avatar chmst chmst - labeled - 17 Jul 2024
avatar chmst chmst - labeled - 17 Jul 2024
avatar dgrammatiko
dgrammatiko - comment - 17 Jul 2024

The reason is that bootstrap uses --bs-name-of-the-variable but Joomla is using --name-of-the-variable, there was an issue: #42074

Is this something we should address now

The sort answer is yes but it needs some work

avatar chmst
chmst - comment - 17 Jul 2024

It is something we should address and I also think that this needs some work. Is it possile to make it compatible with cassiopeia and child templates in existing installations?

avatar brianteeman
brianteeman - comment - 17 Jul 2024

I can easily fix the active colour as shown in the report but thats just a band-aid

avatar brianteeman
brianteeman - comment - 21 Jul 2024

@chmst I reported this as a bug not a feature

avatar Quy Quy - change - 21 Jul 2024
Labels Added: bug
Removed: Feature
avatar Quy Quy - unlabeled - 21 Jul 2024
avatar Quy Quy - labeled - 21 Jul 2024
avatar chmst
chmst - comment - 21 Jul 2024

For me it is not a bug - it does not affect the usage of Joomla. As you said, fixing this now is a band-aid. It should be seen in a bigger context for improvement of the whole frontend template and be planned also with release managers.

avatar brianteeman brianteeman - change - 21 Jul 2024
Status New Closed
Closed_Date 0000-00-00 00:00:00 2024-07-21 15:03:39
Closed_By brianteeman
avatar brianteeman brianteeman - close - 21 Jul 2024
avatar brianteeman
brianteeman - comment - 21 Jul 2024

whatever - guess it will go in the do nothing pile so I am closing it

Add a Comment

Login with GitHub to post a comment