User tests: Successful: Unsuccessful:
This PR removes the deprecated classes Adapter and AdapterInstance. It depends on #43792 and #43793. Those PRs remove the dependency on these classes. Thus this PR can only be merged when those 2 have been merged.
Codereview.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: joomla/Manual#301
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries Front End Plugins |
These classes have been broken sind Joomla 1.5 and have been deprecated since Joomla 4.3. It is impossible to use them without mostly re-implementing them entirely in your own class. There is NO code out there, which can use these classes. There is no gain whatsoever in keeping them.
Labels |
Added:
Feature
b/c break
PR-6.0-dev
|
I have tested this item ✅ successfully on 933e78d
I have successfully confirmed that those 2 files are deleted and the change to the file plugins/behaviour/compat6/src/classmap/classmap.php have been made in the Download package.
I have tested this item ✅ successfully on 933e78d
Tested with JBT and current 6.0-dev
templates/cassiopeia/html/com_content/article/default.php
file in inserting following lines after last use
line 23:
echo "Overwrite is used";
new JAdapter(null, __DIR__, 'Test');
class MyTestAdapter extends JAdapterInstance
{
}
Overwrite is used
and should worklibraries/src/Adapter/AdapterInstance.php
and libraries/src/Adapter/Adapter.php
are deletedAdapterInstance
and Adapter
are removed from plugins/behaviour/compat6/src/classmap/classmap.php
Class "JAdapter" not found
even if 'Behaviour - Backward Compatibility 6' plugin is enabled and 'Classes Aliases' set YesLabels |
Added:
RTC
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-07-30 07:15:43 |
Closed_By | ⇒ | Bodge-IT | |
Labels |
Removed:
RTC
|
Can they be moved to the compat plugin instead and then remove in 7?