Feature b/c break PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
14 Jul 2024

Summary of Changes

This PR removes the deprecated classes Adapter and AdapterInstance. It depends on #43792 and #43793. Those PRs remove the dependency on these classes. Thus this PR can only be merged when those 2 have been merged.

Testing Instructions

Codereview.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#301

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 14 Jul 2024
avatar Hackwar Hackwar - change - 14 Jul 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jul 2024
Category Libraries Front End Plugins
avatar Hackwar Hackwar - change - 24 Aug 2024
The description was changed
avatar Hackwar Hackwar - edited - 24 Aug 2024
avatar laoneo
laoneo - comment - 10 Feb 2025

Can they be moved to the compat plugin instead and then remove in 7?

avatar Hackwar
Hackwar - comment - 14 Feb 2025

These classes have been broken sind Joomla 1.5 and have been deprecated since Joomla 4.3. It is impossible to use them without mostly re-implementing them entirely in your own class. There is NO code out there, which can use these classes. There is no gain whatsoever in keeping them.

avatar Hackwar Hackwar - change - 14 Feb 2025
Labels Added: Feature b/c break PR-6.0-dev
avatar exlemor exlemor - test_item - 17 Jun 2025 - Tested successfully
avatar exlemor
exlemor - comment - 17 Jun 2025

I have tested this item ✅ successfully on 933e78d

I have successfully confirmed that those 2 files are deleted and the change to the file plugins/behaviour/compat6/src/classmap/classmap.php have been made in the Download package.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43794.

avatar muhme muhme - test_item - 27 Jun 2025 - Tested successfully
avatar muhme
muhme - comment - 27 Jun 2025

I have tested this item ✅ successfully on 933e78d

Tested with JBT and current 6.0-dev

  • Enable 'Behaviour - Backward Compatibility 6' plugin and set 'Classes Aliases' Yes
  • Create override: administrator backend -> System -> Site Templates -> Cassiopeia Details and Files -> Create Overrides -> com_content -> article
    • See 'Override created in /templates/cassiopeia/html/com_content/article'
  • Edit templates/cassiopeia/html/com_content/article/default.php file in inserting following lines after last use line 23:
    echo "Overwrite is used";
    new JAdapter(null, __DIR__, 'Test');
    class MyTestAdapter extends JAdapterInstance
    {
    }
    
  • Create an article and show the single article, it must containt Overwrite is used and should work
  • Installed this PR
    • ✅ Checked libraries/src/Adapter/AdapterInstance.php and libraries/src/Adapter/Adapter.php are deleted
    • ✅ Checked AdapterInstance and Adapter are removed from plugins/behaviour/compat6/src/classmap/classmap.php
    • ✅ Article view fails with Class "JAdapter" not found even if 'Behaviour - Backward Compatibility 6' plugin is enabled and 'Classes Aliases' set Yes
      This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43794.
avatar Hackwar Hackwar - alter_testresult - 29 Jul 2025 - muhme: Tested successfully
avatar Hackwar Hackwar - alter_testresult - 29 Jul 2025 - exlemor: Tested successfully
avatar Bodge-IT Bodge-IT - change - 30 Jul 2025
Labels Added: RTC
avatar Bodge-IT Bodge-IT - change - 30 Jul 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-07-30 07:15:43
Closed_By Bodge-IT
Labels Removed: RTC
avatar Bodge-IT Bodge-IT - close - 30 Jul 2025
avatar Bodge-IT Bodge-IT - merge - 30 Jul 2025
avatar Bodge-IT
Bodge-IT - comment - 30 Jul 2025

Thanks for the work on this @Hackwar, nice to get that group of PRs done. Thanks to testers @muhme & @exlemor for testing.

Add a Comment

Login with GitHub to post a comment