PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar artur-stepien
artur-stepien
11 Jul 2024

Fixing the comment in captcha object as it's clearly wrong.

Summary of Changes

Just fixing 2 comments to match what they describe.

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar artur-stepien artur-stepien - open - 11 Jul 2024
avatar artur-stepien artur-stepien - change - 11 Jul 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2024
Category Libraries
avatar chmst chmst - test_item - 11 Jul 2024 - Tested successfully
avatar chmst
chmst - comment - 11 Jul 2024

I have tested this item ✅ successfully on 84a4222

Code Review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43773.

avatar richard67
richard67 - comment - 11 Jul 2024

@artur-stepien The typos exist already in 4.4 so they should be fixed in the 4.4-dev branch. Release managers will later merge it up to the other branches when it has been merged into 4.4-dev.

Could you rebase to or redo on the 4.4-dev branch? Thanks in advance.

avatar ChristineWk ChristineWk - test_item - 11 Jul 2024 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 11 Jul 2024

I have tested this item ✅ successfully on 84a4222

Code Review (J 4.4.6)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43773.

avatar artur-stepien artur-stepien - change - 6 Aug 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-08-06 09:22:04
Closed_By artur-stepien
Labels Added: PR-5.2-dev
avatar artur-stepien artur-stepien - close - 6 Aug 2024
avatar joomla-cms-bot joomla-cms-bot - change - 6 Aug 2024
Category Libraries Unit Tests Repository Administration com_admin com_associations com_banners com_cache com_categories com_checkin
avatar richard67
richard67 - comment - 6 Aug 2024

@chmst @ChristineWk New PR for 4.4-dev is #43888 . Could you "test" that one, too? Thanks in advance.

Add a Comment

Login with GitHub to post a comment