[#43759] - fix PostgreSQL error
- Pending
- Medium
- Build: 4.4-dev
- # 43759
- Diff
- wussup:patch-2
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
for SELECT DISTINCT, ORDER BY expressions must appear in select list
Summary of Changes
remove order by for distinct select
Testing Instructions
access com_finder component with query strings: ?task=suggestions.suggest&format=json&tmpl=component&q=eW
Actual result BEFORE applying this Pull Request
error:
42P10, 7, ERROR: for SELECT DISTINCT, ORDER BY expressions must appear in select list
LINE 6: ORDER BY t.links DESC,t.weight DESC LIMIT 10
^
Warning: foreach() argument must be of type array|object, bool given in \components\com_finder\src\Model\SuggestionsModel.php on line 54
{ "suggestions": [] }
Expected result AFTER applying this Pull Request
{ "suggestions": [] }
Link to documentations
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
Unfortunately this breaks the ordering of the suggestions. This PR unfortunately can't be merged like this.
Then the query needs to be changed so it returns also the columns which are used in the order by, possibly as subquery with the surrounding query returning only the term.
Unfortunately this breaks the ordering of the suggestions. This PR unfortunately can't be merged like this.