[#43757] - fix PostgreSQL error
- Closed
- 8 Jul 2024
- Medium
- Build: 5.1-dev
- # 43757
- Diff
- wussup:patch-1
User tests: Successful: Unsuccessful:
for SELECT DISTINCT, ORDER BY expressions must appear in select list
Summary of Changes
remove order by for distinct select
Testing Instructions
access com_finder component with query strings: ?task=suggestions.suggest&format=json&tmpl=component&q=eW
Actual result BEFORE applying this Pull Request
error:
42P10, 7, ERROR: for SELECT DISTINCT, ORDER BY expressions must appear in select list
LINE 6: ORDER BY t.links DESC,t.weight DESC LIMIT 10
^
Warning: foreach() argument must be of type array|object, bool given in \components\com_finder\src\Model\SuggestionsModel.php on line 54
{ "suggestions": [] }
Expected result AFTER applying this Pull Request
{ "suggestions": [] }
Link to documentations
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
@wussup Thanks a lot for your pull request. By review it looks good to me. However, it seems the bug also exists in 4.4-dev: https://github.com/joomla/joomla-cms/blob/4.4-dev/components/com_finder/src/Model/SuggestionsModel.php#L95-L100 So it should be fixed in 4.4-dev. Release managers will later merge it up into the 5.x-dev and 6.0-dev branches when it has been fixed in 4.4-dev.
Could you rebase our PR to 4.4-dev, or if it's easier for you just make a new one for the 4.4-dev branch?
Thanks in advance.
@richard67 I made a new pull request:
#43759
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-08 14:36:57 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
PR-5.1-dev
|
||
@wussup Thanks a lot for your pull request. By review it looks good to me. However, it seems the bug also exists in 4.4-dev: https://github.com/joomla/joomla-cms/blob/4.4-dev/components/com_finder/src/Model/SuggestionsModel.php#L95-L100
So it should be fixed in 4.4-dev. Release managers will later merge it up into the 5.x-dev and 6.0-dev branches when it has been fixed in 4.4-dev.
Could you rebase our PR to 4.4-dev, or if it's easier for you just make a new one for the 4.4-dev branch?
Thanks in advance.