[#43747] - [5.3] Subformfield groupByFieldset handling - Update default.php
- Pending
- Medium
- Build: 5.2-dev
- # 43747
- Diff
- BrainforgeUK:patch-27
User tests: Successful: Unsuccessful:
groupByFieldset functionality added.
Summary of Changes
Setting groupByFieldset parameter in XML to true does not currently serve any purpose.
This change (without any other fieldset parameters) uses CSS grid display to group fields in a fieldset.
Additional parameters can be used with the fieldset(s) can be used to customise how the fields are grouped (e.g. use flex instead of grid).
Testing Instructions
Install the following plugins:
bfsubfieldtest1.zip
bfsubfieldtest2.zip
bfsubfieldtest3.zip
Actual result BEFORE applying this Pull Request
Go to plugin admin page.
Unexpected result - there is no difference between bfsubfieldtest1 and bfsubfieldtest2.
Expected result AFTER applying this Pull Request
Go to plugin admin page.
With bfsubfieldtest2 the the fields are now grouped by fieldset.
bfsubfieldtest3 illustrates how the appearance of fields grouped within fieldsets can be customised.
Link to documentations
The code in this pull request includes comments about the available fieldset attributes. These comments together with the example subform fields from bfsubfieldtest3 need to be included in the documentation.
Please select:
-
[*] Documentation link for docs.joomla.org:
Avanced Form Guide
Subform Form Field -
[] No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Title |
|
||||||
| Labels |
Added:
PR-5.2-dev
|
||
Thanks for the PR, a few notes:
- Please remove iinline style, CSS in XML will not be accepted. You can use only class.
- Please use
foreach(): ... endforeach;andif (): ... endifin the code that mixing PHP and HTML.
| Title |
|
||||||
| Labels |
Added:
Feature
|
||
Phan failing - is that something for me to address?
we really should not be using inline styles
Phan failing - is that something for me to address?
@BrainforgeUK No. Phan is expected to fail.
But you should check the other reviews by others. And you shouldn’t use inline styles as that will not allow to use a strict CSP.
I have tested this item ✅ successfully on 9a598f2
I can see the difference between the two plugin.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43747.
I have tested this item ✅ successfully on 9a598f2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43747.
Not setting RTC despite of the 2 successful human tests as this PR adds inline styles which will result in CSP violations when using a reasonably strict CSP rule.
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
@BrainforgeUK Please fix the PHP code style errors reported here: https://ci.joomla.org/joomla/joomla-cms/77074/1/7