[#43739] - [5.4] success / message type not mapped to SymfonyStyle in ConsoleApplication
- Fixed in Code Base
- 28 Nov 2025
- Medium
- Build: 5.2-dev
- # 43739
- Diff
- brbrbr:msg-log-console
User tests: Successful: Unsuccessful:
Let's retry PR #43688
Pull Request for Issue #43683 .
Summary of Changes
Added missing message type mapping from enqueued message to SymfonyStyle
Testing Instructions
Execute a CLI command calling a script with enqueueMessage with type success.
Or code review.
Actual result BEFORE applying this Pull Request
success message are displayed as SymfonyStyle comment
Expected result AFTER applying this Pull Request
success message are displayed as SymfonyStyle success
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Libraries |
| Labels |
Added:
PR-5.2-dev
|
||
Not sure why you change the order of the properties, the reason is the verbosity and is the same as PSR-3
Also changing code style / ordering makes it really hard to review it because the only relevant change is adding 2 lines in ConsoleApplication.php, I'm not sure about the new constant added to the application. It might be used in joomla, but makes it hard to map on psr-3 and other logging systems, so sticking to the existing constants might make sense.
Just update the console application should be enough from my pov
I changed the order in message.php/CMSApplicationInterface.php to be consistent with ConsoleApplication.php. Alphabetically as in message.php seemed right. I wasn't aware of the PSR-3 order as it is not described in any of the files
Shouldn't the order in libraries/src/Application/ConsoleApplication.php be according to PSR-3 as well?
| Labels |
Added:
bug
|
||
| Category | Layout Libraries | ⇒ | Libraries |
| Title |
|
||||||
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
| Labels |
Added:
PR-5.3-dev
|
||
This pull request has been automatically rebased to 5.4-dev.
| Title |
|
||||||
| Labels |
Added:
PR-5.4-dev
Removed: PR-5.2-dev PR-5.3-dev |
||
PHPstan fails due to access to undefined constant Joomla\CMS\Application\ConsoleApplication::MSG_MESSAGE.
System tests fail for the same reason.
| Category | Libraries | ⇒ | Layout Libraries |
| Labels |
Added:
Updates Requested
|
||
| Labels |
Removed:
Updates Requested
|
||
I have tested this item ✅ successfully on 9901be7
Tested with JBT and own-developed DemoEnqueueSuccess.zip plugin:
- Installed and enabled plugin plg_system_democommand, seen raw black-white
php cli/joomla.php demo:enqueue-success
[INFO]
// All good — success from CLI!
Applied PR with Patch Tester and seen nice green OK:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43739.
I have tested this item ✅ successfully on 9901be7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43739.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43739.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-11-28 16:09:11 |
| Closed_By | ⇒ | richard67 |
Thanks @brbrbr for your bug fix, and thanks @muhme and @ThomasFinnern for testing.
I have tested this item ✅ successfully on 9975b35
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43739.