User tests: Successful: Unsuccessful:
According to our new development strategy:
http://developer.joomla.org/news/586-joomla-development-strategy.html#version_numbering
We don't use LTS or STS anymore.
@roland-d can you have a look into this as the initial PR was yours? Thanks
See also #3681
Labels |
Added:
?
|
Category | ⇒ | Language & Strings Updating |
Title |
|
Title |
|
@zero-24 Thanks for the clarification. You can't change it because the language strings are already comitted but only available in 3.4. I do think the other files should also be available on 3.4-dev. I guess it is fine as long as it is clear that both changes are for 3.4-dev.
Milestone |
Added: |
Status | Pending | ⇒ | Ready to Commit |
I have just add a @deprecated Message for the two lang strings that need to change in 4.0 and moving to RTC Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4373.
You change the current language strings and deprecate them with a message to use the new ones. But the new ones don't exist. Or I am blind
Yes. We can't change the strings in a B/C way so we need to deprecate it for 4.0.
If we ready for 4.0 we need to change the values here:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_joomlaupdate/config.xml#L16
and here:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_joomlaupdate/models/default.php#L35-45
Then we can change the strings to the new values.
No isses. Merged, thanks!
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-08 13:34:23 |
Sorry folks. The messages are totally confusing.
See the use of "current major release" in both cases.
When choosing in joomlaupdate "Current Major Release", we get the message
" You are connected to the Short Term Support update stream - This stream is designed for major releases and provides all major, minor and patch updates. So you are always on the last version of Joomla!.
You already have the latest Joomla! version, 3.4.0-alpha. "
When using "Current Minor and patch Release" we get
" You are connected to the Long Term Support (recommended) update stream - This stream is designed for the current major release and provides all minor and patch updates of your version until the support for your version ends.
You already have the latest Joomla! version, 3.4.0-alpha. "
Please urgently propose a change before I freeze languages.
The whole STS/LTS thing seems to still be hardcoded into the system. Right now, a Joomla 3.x release should have 3 channels and thus 3 messages:
None of this seems to be present in the current system.
at least not from the language perspective.
3.2 support ended October 31 so that isn't an issue going forward.
ok, that reduces the number of choices down to 2. For now. When we have 3.x and 4.x in parallel, we will have 4 at that time...
When we have 3.x and 4.x in parallel, we will have 4 at that time...
The release of 4.0 doesn't change anything. You still need:
testing will take nightlies.
Until 4.0 however there will be no difference between the first two options.
With 4.0 we will have:
I disagree with a "major" and "minor" release channel, because we might even have situations where we have to support 3 or more major versions in parallel. Remember that we are promising 2 full years of support for each major version starting from the last minor release. If we release 4.0 in 2015 and 5.0 at the beginning of 2016, we will have to support 3.x, 4.x and 5.x. But that is nitpicking.
Anyway, the current text is absolutely confusing and needs to be changed before we release 3.4.
The streams and options are the same for 3.x and 4.x, multiple active branches don't multiplicate the options.
The streams are here: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_joomlaupdate/models/default.php#L35 and they're exactly the same for the 2.5 branch: https://github.com/joomla/joomla-cms/blob/2.5.x/administrator/components/com_joomlaupdate/models/default.php#L33
I disagree with a "major" and "minor" release channel, because we might even have situations where we have to support 3 or more major versions in parallel.
Doesn't matter how many active majors we have. It's always either "stay in current major and get only newest minor and patch (minor)" or "jump to latest release (major)" plus "get nightly for current major (testing)".
Anyway, the current text is absolutely confusing and needs to be changed before we release 3.4.
Can't be worse than what we have in 3.3
But feel free to propose a better text. I only disagree that it's a show stopper for 3.4. It's far from being a major issue.
we have some options to fix this issue
Change this to use Major or minor:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_joomlaupdate/views/default/tmpl/default.php#L14-16
Or change here:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_joomlaupdate/config.xml#L16-21
Or change this language strings:
https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.com_joomlaupdate.ini#L14-20
We still can change the language strings confusion before beta which is (as far as I know) forecasted for December 2nd. It is not indeed a stopper.
We still can change the language strings confusion
sure e.g:
Or change this language strings (Language B/C break):
https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.com_joomlaupdate.ini#L14-20
; @deprecated for 4.0 -> COM_JOOMLAUPDATE_CONFIG_UPDATESOURCE_LTS
COM_JOOMLAUPDATE_CONFIG_UPDATESOURCE_LTS="Current Minor & Patch Release (recommended)"
COM_JOOMLAUPDATE_CONFIG_UPDATESOURCE_MAJOR="Current Major Release"
COM_JOOMLAUPDATE_CONFIG_UPDATESOURCE_MINOR="Current Minor & Patch Release (recommended)"
COM_JOOMLAUPDATE_CONFIG_UPDATESOURCE_NOCHANGE="Currently configured (no change)"
; @deprecated for 4.0 -> COM_JOOMLAUPDATE_CONFIG_UPDATESOURCE_STS
COM_JOOMLAUPDATE_CONFIG_UPDATESOURCE_STS="Current Major Release"
But I don't know which solution we should choose from here: #4373 (comment)
I am speaking of these strings:
COM_JOOMLAUPDATE_VIEW_DEFAULT_UPDATES_INFO_LTS="You are connected to the %s update stream - This stream is designed for the current major release and provides all minor and patch updates of your version until the support for your version ends."
and
COM_JOOMLAUPDATE_VIEW_DEFAULT_UPDATES_INFO_STS="You are connected to the %s update stream - This stream is designed for major releases and provides all major, minor and patch updates. So you are always on the last version of Joomla!."
@infograf768 ok. What kind of change you what with this both strings?
If we use this "fix" #4373 (comment) we have this messages:
" You are connected to the Current Major Release update stream - This stream is designed for major releases and provides all major, minor and patch updates. So you are always on the last version of Joomla!.
" You are connected to the Current Minor & Patch Release (recommended) update stream - This stream is designed for the current major release and provides all minor and patch updates of your version until the support for your version ends.
So also here no LTS / STS anymore. Or did you mean the wording?
You are connected to the Current Minor & Patch Release (recommended) update stream
and
You are connected to the Current Major Release update stream
The confusion is the use of the term "major release(s)" in both cases I quoted above ( #4373 (comment) ). Would it be "Current" or not.
@brianteeman
Can you please have a look?
Will do in a while. Got a client on emergency
On 25 Nov 2014 06:05, "infograf768" notifications@github.com wrote:
@brianteeman https://github.com/brianteeman
Can you please have a look?—
Reply to this email directly or view it on GitHub
#4373 (comment).
@zero-24 How is this PR different from #3681? I don't really understand the difference for these 2 PRs, it almost looks like it should be 1 PR.