Language Change NPM Resource Changed PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
30 Jun 2024

Pull Request for Issue #43708 .

Summary of Changes

This PR will adjust the styling of the alert boxes. Overrides are done using css custom properties instead of overriding css attributes.

Testing Instructions

I've used the following html to test alert boxes

<div class="alert" role="alert">
    class="alert"<br/>
    A simple primary alert—check it out! <a href="#" class="btn btn-primary">button</a>
</div>
<div class="alert alert-primary" role="alert">
    class="alert alert-primary"<br/>
    A simple primary alert—check it out! <a href="#" class="btn btn-primary">button</a>
</div>
<div class="alert alert-secondary" role="alert">
    class="alert alert-secondary"<br/>
    A simple secondary alert—check it out! <a href="#" class="btn btn-secondary">button</a>
</div>
<div class="alert alert-success" role="alert">
    class="alert alert-success"<br/>
    A simple success alert—check it out! <a href="#" class="btn btn-success">button</a>
</div>
<div class="alert alert-danger" role="alert">
    class="alert alert-danger"<br/>
    A simple danger alert—check it out! <a href="#" class="btn btn-danger">button</a>
</div>
<div class="alert alert-warning" role="alert">
    class="alert alert-warning"<br/>
    A simple warning alert—check it out! <a href="#" class="btn btn-warning">button</a>
</div>
<div class="alert alert-info" role="alert">
    class="alert alert-info"<br/>
    A simple info alert—check it out! <a href="#" class="btn btn-info">button</a>
</div>
<div class="alert alert-light" role="alert">
    class="alert alert-light"<br/>
    A simple light alert—check it out! <a href="#" class="btn btn-light">button</a>
</div>
<div class="alert alert-dark" role="alert">
    class="alert alert-dark"<br/>
    A simple dark alert—check it out! <a href="#" class="btn btn-dark">button</a>
</div>

Actual result BEFORE applying this Pull Request

Screenshot 2024-06-30 at 20 49 28 Screenshot 2024-06-30 at 20 49 18

Expected result AFTER applying this Pull Request

Screenshot 2024-06-30 at 20 30 24 Screenshot 2024-06-30 at 20 30 13

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar hans2103 hans2103 - open - 30 Jun 2024
avatar hans2103 hans2103 - change - 30 Jun 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jun 2024
Category Repository NPM Change Installation Language & Strings
avatar hans2103 hans2103 - change - 30 Jun 2024
The description was changed
avatar hans2103 hans2103 - edited - 30 Jun 2024
avatar hans2103 hans2103 - change - 30 Jun 2024
Labels Added: Language Change NPM Resource Changed PR-5.2-dev
avatar hans2103
hans2103 - comment - 30 Jun 2024

hmmmm... something odd with this PR. I only wanted to adjust two files.
Seems like 69 have been updated.

Closing this PR to create a new proper one
My bad

avatar hans2103 hans2103 - change - 30 Jun 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-06-30 18:51:17
Closed_By hans2103
avatar hans2103 hans2103 - close - 30 Jun 2024

Add a Comment

Login with GitHub to post a comment