[#43716] - [5.1] Allow PDF embeding again
- Fixed in Code Base
- 2 Jul 2024
- Medium
- Build: 5.1-dev
- # 43716
- Diff
- bembelimen:tinymce/fix-security-change
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #43407 & #43365 .
Summary of Changes
The security hardening adds an empty "sandbox" attribute to every iframe (read more). This prevents PDFs insert by the media manager loaded (it needs more fine granulated sandbox values)
With TinyMCE 7 you can whitelist certain domains, which will overcome this problem, but till then, this filter is super strict and not usable.
Testing Instructions
Use the media manager to embed a PDF. Save the article and open article in frontpage.
Actual result BEFORE applying this Pull Request
- PDF is blocked
Expected result AFTER applying this Pull Request
-
Go to the TinyMCE configuration and disable the following option:
-
PDF is visible
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Revert broken security fix
It's not broken and it's not a "bug". It's exactly doing what it's supposed to do: it limits the possible actions that an iframe can perform to protect the user from unexpected script execution.
So, the question actually is: does the CMS want to enforce the strictest possible security configuration for the editor, at least by default? Or is the comfort in the content creation process more important?
That's a question that's probably worth a vote in the production department meeting.
I'm for security, of course, but it should at least be possible to embed a local PDF ...
#43407 (comment)
I have tested this item ✅ successfully on 46a404f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43716.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43716.
TBH, I have no idea why it is called security,
Crossorigin is not easy to bypass without extra effort, by just embed iframe,
And all local embendings, well, they will be need to be enabled in one or in another way.
We just making life for average User more complicated. They can just switch to codemirror, or none editor, and all this "theorethical security" will disapears.
We are not talking about a CORS but about user experience and perception. Imagine an editor copy&pasting an iframe tag to an external site into the editor window of his companies intranet. On paste, the iframe will be loaded automatically - and without sandboxing, that iframe could i.e. trigger a file download. The user is now under the impression that this download is triggered by a trusted source, which is the Joomla administrator interface of his intranet - whereas the download is actually triggered by the untrusted iframe site.
I'm not necessarily saying, that this is an important threat scenario for the average user, I just want to point out that the issue is not related to crossorigin or samesite policies.
We can make a TinyMCE plugin, that shows an alert for potentialy dangerous iframe (and let User decide what to do), when User insert something in the editor. instead of totaly blocking everything.
Maybe its an option to extend the TinyMCE plugin with the basic configuration for the sandbox parameters so a domain could be added to allow the PDF iframe?
Quy
- | Status | Ready to Commit | ⇒ | Pending |
| Labels |
Added:
bug
PR-5.1-dev
|
||
| Category | Front End Plugins | ⇒ | Administration Language & Strings Front End Plugins |
| Labels |
Added:
Language Change
|
||
Now with parameter. Ready to test again :)
| Title |
|
||||||
I have tested this item ✅ successfully on 12ac335
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43716.
I have tested this item ✅ successfully on 12ac335
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43716.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43716.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-02 05:50:04 |
| Closed_By | ⇒ | LadySolveig |
Thank you @bembelimen and also for testing and review @drmenzelit @SniperSister @RickR2H @Fedik @brianteeman
I have tested this item ✅ successfully on 46a404f
Thank you
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43716.