Feature PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar sakiss
sakiss
24 Jun 2024

Pull Request for Issue #42579

Summary of Changes

So far the Integer custom field is a drop-down list.
Though it is crashing the browser when the list becomes too long. Moreover it is really hard to use, after a certain length.

With the PR the Integer custom field is an input of type number. Though, it still follows the min, max and step settings, that existed.

Testing Instructions

Try setting up a custom field of type "Integer" for an article.
Within the article you will see an input, instead of a drop-down,

Actual result BEFORE applying this Pull Request

Drop-down list.

Expected result AFTER applying this Pull Request

Input of type number

Link to documentations

DKN

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar sakiss sakiss - open - 24 Jun 2024
avatar sakiss sakiss - change - 24 Jun 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jun 2024
Category Unit Tests Repository Administration com_admin SQL
avatar sakiss sakiss - change - 24 Jun 2024
Title
Integer custom field to be numerical
Integer custom field to be numerical input instead of a drop-down
avatar sakiss sakiss - edited - 24 Jun 2024
avatar sakiss sakiss - change - 24 Jun 2024
Labels Added: Unit/System Tests PR-4.4-dev
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jun 2024
Category Unit Tests Repository Administration com_admin SQL Libraries Front End Plugins
avatar sakiss sakiss - change - 24 Jun 2024
Labels Added: PR-5.2-dev
Removed: Unit/System Tests
avatar Fedik
Fedik - comment - 24 Jun 2024

Thanks for the PR.
Before you continue. We should not change existing integer field. And instead of it, need to create a new Number custom field, which will use NumberField class.

avatar sakiss sakiss - change - 25 Jun 2024
The description was changed
avatar sakiss sakiss - edited - 25 Jun 2024
avatar sakiss sakiss - change - 25 Jun 2024
The description was changed
avatar sakiss sakiss - edited - 25 Jun 2024
avatar sakiss sakiss - change - 25 Jun 2024
The description was changed
avatar sakiss sakiss - edited - 25 Jun 2024
avatar sakiss sakiss - change - 4 Jul 2024
Labels Added: Feature
Removed: PR-4.4-dev
avatar sakiss sakiss - change - 9 Jul 2024
Title
Integer custom field to be numerical input instead of a drop-down
[5.2] Integer custom field to be numerical input instead of a drop-down
avatar sakiss sakiss - edited - 9 Jul 2024
avatar crommie crommie - test_item - 24 Aug 2024 - Tested successfully
avatar crommie
crommie - comment - 24 Aug 2024

I have tested this item ✅ successfully on a8e9be4

This does what it says. But Fedik's suggestion below sounds logical to me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43697.

avatar pe7er pe7er - test_item - 24 Aug 2024 - Tested successfully
avatar pe7er
pe7er - comment - 24 Aug 2024

I have tested this item ✅ successfully on a8e9be4

Works like described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43697.

avatar brianteeman
brianteeman - comment - 24 Aug 2024

This breaks backwards compatibility and should be a new field

avatar richard67
richard67 - comment - 24 Aug 2024

Not setting RTC due to reason stated in previous comment. The "Updates requested" label is already set.

avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
[5.2] Integer custom field to be numerical input instead of a drop-down
[5.3] Integer custom field to be numerical input instead of a drop-down
avatar HLeithner HLeithner - edited - 2 Sep 2024

Add a Comment

Login with GitHub to post a comment