[#43694] - [5.2] Created translatable strings for LocalAdapter.php "code review"
- Fixed in Code Base
- 18 Sep 2024
- Medium
- Build: 4.4-dev
- # 43694
- Diff
- webmasterab:4.4-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This is new to me.
If I did it wrong please let me know.
Summary of Changes
I changed fixed translation to translatable strings
Testing Instructions
"code review"
It's only changed in the code.
I converted the fixed value of the error message into a translatable string
Actual result BEFORE applying this Pull Request
In localAdapter.php there was untranslatable text.
Expected result AFTER applying this Pull Request
In localAdapter.php the text is now translatable using string
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
[X ] No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
[ X] No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Front End Plugins |
| Title |
|
||||||
| Labels |
Added:
Language Change
PR-4.4-dev
|
||
| Title |
|
||||||
I have tested this item ? unsuccessfully on a07d5c2Tested briefly in Joomla 4.4.6-dev. The language strings should be added also to administrator/language/en-GB/com_media.ini. Value: COM_MEDIA_MOVE_FILE_NOT_POSSIBLE="COM_MEDIA_MOVE_FILE_NOT_POSSIBLE"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43694.
Thank you for your test.
Too bad this didn't work out.
I understand why you marked it as unsuccessful.
How can I update this request so that I can also put the missing translations in the admin's.
Or should I make another request for this?
| Category | Language & Strings Front End Plugins | ⇒ | Administration Language & Strings Front End Plugins |
I have tested this item ✅ successfully on 0b36e42
Tested successfully in Joomla 4.4.6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43694.
I have tested this item ✅ successfully on 2316500
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43694.
I have tested this item ✅ successfully on 2316500
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43694.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43694.
| Labels |
Added:
RTC
|
||
it has not been merged yet
@brianteeman Thank you for explaining.
I saw that it was merged with joomla-dev4.4 so I thought it worked.
I'm waiting
Before I can merge, you need to resolve the conversation. If it is not fixed and you need to make an adjustment with a new commit, then we need another round of testing.
Before I can merge, you need to resolve the conversation. If it is not fixed and you need to make an adjustment with a new commit, then we need another round of testing.
Found it and solved it.
| Title |
|
||||||
| Category | Language & Strings Front End Plugins Administration | ⇒ | Administration Language & Strings Front End com_content Plugins |
I'v rebased this to 5.2. As soon as 5.2 gets the upmerges from 4.4 we can update this one too and the conflicts will be gone.
| Labels |
Added:
PR-5.2-dev
|
||
| Labels |
Removed:
PR-4.4-dev
|
||
| Category | Language & Strings Front End Plugins Administration com_content | ⇒ | Administration Language & Strings Front End Plugins |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-18 21:10:56 |
| Closed_By | ⇒ | Hackwar |
Thanks for your contribution @webmasterab!
I have tested this item ? unsuccessfully on a07d5c2
Tested briefly in Joomla 4.4.6-dev. The language strings should be added also to administrator/language/en-GB/com_media.ini. Value: COM_MEDIA_MOVE_FILE_NOT_POSSIBLE="COM_MEDIA_MOVE_FILE_NOT_POSSIBLE"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43694.