RTC PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
22 Jun 2024

Summary of Changes

Right now we have the ability to disable the RSS link in the header of different views, however that only hides the link in the output. You can still access the RSS output when simply typing in the URL. This PR disables the output when the link is disabled.

Testing Instructions

Go to any view which also provides a feed output and open the options for its menu item or change the the global configuration of the component to disable showing the feed link.

Actual result BEFORE applying this Pull Request

You can still access the output of the RSS feed.

Expected result AFTER applying this Pull Request

You get a 404 "Resource not found" result.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 22 Jun 2024
avatar Hackwar Hackwar - change - 22 Jun 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jun 2024
Category Front End com_content com_finder com_tags Libraries
avatar Hackwar Hackwar - change - 8 Jul 2024
Labels Added: PR-5.2-dev
avatar webnet-assmann webnet-assmann - test_item - 23 Jul 2024 - Tested successfully
avatar webnet-assmann
webnet-assmann - comment - 23 Jul 2024

I have tested this item ✅ successfully on 3c50bfc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43692.

avatar fgsw
fgsw - comment - 1 Aug 2024

@Hackwar Is a test useful even "This branch is out-of-date with the base branch"?

avatar brianteeman
brianteeman - comment - 1 Aug 2024

@Hackwar Is a test useful even "This branch is out-of-date with the base branch"?

as long as there are no conflicts then yes

avatar fgsw fgsw - test_item - 1 Aug 2024 - Tested successfully
avatar fgsw
fgsw - comment - 1 Aug 2024

I have tested this item ✅ successfully on 3c50bfc

Test on a multilingual site.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43692.

avatar fgsw
fgsw - comment - 3 Aug 2024

Ready To Commit?

avatar Hackwar Hackwar - change - 3 Aug 2024
Status Pending Ready to Commit
avatar Hackwar Hackwar - change - 3 Aug 2024
Labels Added: RTC
avatar pe7er pe7er - close - 8 Aug 2024
avatar pe7er pe7er - merge - 8 Aug 2024
avatar pe7er pe7er - change - 8 Aug 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-08-08 20:50:25
Closed_By pe7er
avatar pe7er
pe7er - comment - 8 Aug 2024

Thanks @Hackwar !

Add a Comment

Login with GitHub to post a comment