[#43672] - [6.0] fix #43668 PluginAdapter checkExistingExtension does not load plugin
- Pending
- Medium
- Build: 4.4-dev
- # 43672
- Diff
- svanschu:43668-PluginAdapter
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #43668 .
Summary of Changes
Do the same extension load in the checkExistingExtension as for InstallerAdapter
Testing Instructions
Try to install a plugin as update and get the information of the current installed plugin in the preflight.
For example
public function preflight(string $type, InstallerAdapter $parent): bool
{
$cache = new Registry($parent->extension->manifest_cache);
$this->oldVersion = $cache->get('version');
return true;
}
Actual result BEFORE applying this Pull Request
$this->oldVersion = null
Expected result AFTER applying this Pull Request
$this->oldVersion = <the actual currently installed version>
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
This pull request has been automatically rebased to 6.0-dev.
| Title |
|
||||||
Hi @svanschu, I would love to test this for you, as I am sure others as well, but since I don't talk, sleep code like our wonderful developers (I wish), I don't know how to test this for you, if you could update the testing instructions that would be great, thanks.
Hi. How you would expect the testing instructions to be made? You would need a simple plugin two time with different version numbers. In the installation script it tries to get the version number of the installed plugin version. Without page it fails, with patch it gets that version string.
What would you need to do the test?
This pull request has been automatically rebased to 5.3-dev.