RTC NPM Resource Changed PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar RickR2H
RickR2H
12 Jun 2024

Pull Request for Issue # .

Summary of Changes

The chevron in the Module menu Assignment in light mode is not visible. In dark mode the chevron is visible.

module-light-mode
module-dark-mode

I used the default link color as new color.

Testing Instructions

  • Checkout this PR and build the CSS with: npm run build:css
  • Set the template to light mode
  • Check if the chevron is visible

Actual result BEFORE applying this Pull Request

Chevron not visible

Expected result AFTER applying this Pull Request

Chevron is visible

module-light-mode-fixed

avatar RickR2H RickR2H - open - 12 Jun 2024
avatar RickR2H RickR2H - change - 12 Jun 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jun 2024
Category Repository NPM Change
avatar RickR2H RickR2H - change - 12 Jun 2024
Labels Added: NPM Resource Changed PR-5.2-dev
avatar Quy Quy - test_item - 12 Jun 2024 - Tested successfully
avatar Quy
Quy - comment - 12 Jun 2024

I have tested this item ✅ successfully on 8cc4aaf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645.

avatar carlitorweb carlitorweb - test_item - 12 Jun 2024 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 12 Jun 2024

I have tested this item ✅ successfully on 8cc4aaf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645.

avatar Quy Quy - change - 12 Jun 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Jun 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645.

avatar Quy Quy - change - 12 Jun 2024
Labels Added: RTC
avatar brianteeman
brianteeman - comment - 12 Jun 2024

Something sees odd here - the css being changed was only recently added #43160

Did not work then (we need to improve our testing) or has another PR somewhere else changed the behaviour

avatar RickR2H RickR2H - change - 13 Jun 2024
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2024-06-13 07:08:37
Closed_By RickR2H
avatar RickR2H RickR2H - close - 13 Jun 2024
avatar RickR2H
RickR2H - comment - 13 Jun 2024

PR is closed due to some solution is merged already #43160.

avatar brianteeman
brianteeman - comment - 13 Jun 2024

This PR is needed.

Did not work then (we need to improve our testing) or has another PR somewhere else changed the behaviour

avatar RickR2H RickR2H - change - 13 Jun 2024
Status Closed New
Closed_Date 2024-06-13 07:08:37
Closed_By RickR2H
Labels Removed: RTC
avatar RickR2H RickR2H - change - 13 Jun 2024
Status New Pending
avatar RickR2H RickR2H - reopen - 13 Jun 2024
avatar RickR2H
RickR2H - comment - 13 Jun 2024

@brianteeman Re-opened

avatar RickR2H RickR2H - change - 13 Jun 2024
Status Pending Ready to Commit
avatar RickR2H RickR2H - alter_testresult - 13 Jun 2024 - 2: Tested successfully
avatar RickR2H
RickR2H - comment - 13 Jun 2024

Was closed before so the successful tests where reset. No code has been changed so added the tests and RTC status again.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645.

avatar RickR2H
RickR2H - comment - 13 Jun 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645.

avatar RickR2H RickR2H - alter_testresult - 13 Jun 2024 - carlitorweb: Tested successfully
avatar RickR2H RickR2H - alter_testresult - 13 Jun 2024 - Quy: Tested successfully
avatar Quy Quy - change - 14 Jun 2024
Labels Added: RTC
avatar pe7er pe7er - change - 18 Jun 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-06-18 07:07:44
Closed_By pe7er
avatar pe7er pe7er - close - 18 Jun 2024
avatar pe7er pe7er - merge - 18 Jun 2024
avatar pe7er
pe7er - comment - 18 Jun 2024

Thanks @RickR2H !

Add a Comment

Login with GitHub to post a comment