Joomla! Issue Tracker | Joomla! CMS #43605 - Remove legacy code in updater

Feature No Code Attached Yet

New
Medium
Build: 4.4-dev
# 43605

HLeithner
3 Jun 2024

Joomla updater has code for old CMS Version, was useful for Versions < 4.0

joomla-cms/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php

Lines 175 to 179 in dfb572d

    
           $reflection       = new \ReflectionObject($updater); 
        
           $reflectionMethod = $reflection->getMethod('findUpdates'); 
        
           $methodParameters = $reflectionMethod->getParameters(); 
        
           if (\count($methodParameters) >= 4) {

I would expect that this code part could be removed.

HLeithner - open - 3 Jun 2024

joomla-cms-bot - change - 3 Jun 2024

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 3 Jun 2024

Hackwar - change - 28 Nov 2024

Labels

Added: Feature

Hackwar - labeled - 28 Nov 2024

Hackwar - comment - 28 Nov 2024

Marking this as feature, since it isn't technically a bug and would have to be done in a minor or major version.

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#43605] - Remove legacy code in updater

Add a Comment

	$reflection = new \ReflectionObject($updater);
	$reflectionMethod = $reflection->getMethod('findUpdates');
	$methodParameters = $reflectionMethod->getParameters();

	if (\count($methodParameters) >= 4) {