[#43604] - Don't throw an error on Path::clean() if $metaPath isn't found
- Fixed in Code Base
- 12 Jun 2024
- Medium
- Build: 5.1-dev
- # 43604
- Diff
- OctavianC:patch-6
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #43580 .
Summary of Changes
Path::find() returns false if the location cannot be found and Path::clean() throws an error if a non-string value is supplied - this makes menu item editing impossible for components that have been uninstalled.
Testing Instructions
See issue #43580
Actual result BEFORE applying this Pull Request
You must specify a non-empty path to clean
Expected result AFTER applying this Pull Request
Menu item editing page opens correctly
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
Thank you @OctavianC - I can confirm your change works. :-)
Thanks for testing, @sousa9g and @bcraigie. Could you please go to https://issues.joomla.org/tracker/joomla-cms/43604 and confirm your test with the "Test this" Button? Then the patch can be released.
| Labels |
Added:
PR-5.1-dev
|
||
Merging this between the two tests not registered in the tracker and on review
I have tested this item ✅ successfully on 437b42a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43604.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-06-12 19:45:46 |
| Closed_By | ⇒ | wilsonge |
Tested successfully, worked fine for me.