User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This pull request (PR) implements an initial clean up of scripts related to core updates for the new major version 6.0 by doing 5 things:
6.0.0-2024-06-01.sql
is added for each database type so that the folders will not be empty. The script contains a comment on what to do with it when the first real update SQL script for 6.0 will be added.administrator/components/com_admin/script.php
for 6.0 byupdateAssets
method in file administrator/components/com_admin/script.php
by obsolete entries from 5.x.uninstallExtensions
and postflight
methods and adapt version checks in these methods to 6.0.build/deleted_file_check.php
script which is used to create the lists of deleted files and folders and renamed files in the administrator/components/com_admin/script.php
file.Code review by an experienced maintainer or release manager who is familiar with the update process should be sufficient.
But if you want to do real tests:
Update the latest 5.2 nightly build or a 5.2.0-alpha1 to the latest 6.0 nightly build to get the actual result, and update latest 5.2 nightly build or a 5.2.0-alpha1 to the patched package created by Drone for this PR to get the expected result.
Here you can find the patched update package or custom update URL created by Drone for this PR: https://artifacts.joomla.org/drone/joomla/joomla-cms/6.0-dev/43598/downloads/76503/
After the update
administrator/components/com_admin/sql/updates/mysql
and administrator/components/com_admin/sql/updates/postgresql
,The tests require PHP CLI so you can run PHP scripts on a command line (Linux shell or Windows CMD, no need for WSL) and a local Git clone of the 6.0-dev branch so the build
folder is available. They can be executed on a clean branch without the need to run composer install
or npm install
, but if they have been run it will not do any harm.
The instructions below are made with Linux file paths, i.e. separator /
. When being on Windows, just replace that by a backslash \
.
tmp
folder of your Git clone and folder names equal to the files base names of the packages, the folders will be:php ./build/deleted_file_check.php --from=./tmp/Joomla_5.2.0-alpha1-dev-Development-Full_Package --to=./tmp/Joomla_6.0.0-alpha-dev-Development-Full_Package
./build/deleted_files.txt
and ./build/deleted_folders.txt
have been created, but no text file ./build/renamed_files.txt
.build/deleted_file_check.php
from this PR, but only the changes in that file and not the other changes.In folders folders administrator/components/com_admin/sql/updates/mysql
and administrator/components/com_admin/sql/updates/postgresql
there are all 5.x update SQL scripts from 5.2, and these were even updated because they are in the update package of the nightly build.
The files and folders which have been deleted in the source code with PRs #42884 and #42890 are still present after the update.
The script creates text files ./build/deleted_files.txt
and ./build/deleted_folders.txt
, but no text file ./build/renamed_files.txt
In folders folders administrator/components/com_admin/sql/updates/mysql
and administrator/components/com_admin/sql/updates/postgresql
there are no 5.x update SQL scripts. Only one update SQL script 6.0.0-2024-06-01.sql
is present, which includes only a comment on what to do when the first real update SQL script for 6.0 will be added.
The files and folders which have been deleted in the source code with PRs #42884 and #42890 have been deleted by the update.
There are no other differences compared to the actual result on filesystem or database except of expected differences like e.g. the superadmin's user ID, creation times or such things.
The script creates text files ./build/deleted_files.txt
and ./build/deleted_folders.txt
, but no text file ./build/renamed_files.txt
The ./build/deleted_files.txt
and ./build/deleted_folders.txt
files are the same as without this PR.
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_admin SQL Postgresql |
Labels |
Added:
PR-6.0-dev
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-06-05 17:22:19 |
Closed_By | ⇒ | HLeithner |
thanks