[#43586] - [4.4] Remove unused cassiopeia inline event handler
- Fixed in Code Base
- 14 Jun 2024
- Medium
- Build: 5.1-dev
- # 43586
- Diff
- SniperSister:5.1-cassopeia-inline-event-handler
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
The current Cassiopeia version has an inline onload event handler for the fontscheme.current css file. The inline event handler produces a warning in strict CSP mode and is redundant, as the lazy-loading functionality (that was the purpose of the handler) is handled in the template.js and trigger by the rel="lazy-stylesheet" attribute.
Testing Instructions
- Configure the "roboto (local)" font as font in cassiopeia, verify that it's loaded by the browser using the browser dev tools.
- Configure a strict ("script-src: 'self' 'unsafe-eval'") report-only script CSP using the Joomla HTTP Header plugin:
Actual result BEFORE applying this Pull Request
- CSS file loaded
- Error message about forbidden unsafe-inline JS calls, caused by an "onload" handler of the mentioned CSS file in the browser console shown
Expected result AFTER applying this Pull Request
- CSS file loaded
- Error message about unsafe-inline calls about the onload handler is gone
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
[x ] No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
Also does the same change need to be made in
templates\cassiopeia\component.php
templates\cassiopeia\error.php
| Labels |
Added:
PR-5.1-dev
|
||
Lesson learned: don't commit while listening to JDay presentations ;)
Sorry guys, now all required changes (removal of inline handler, removal of unused media attribute) have been performed in all relevant files and locations.
As stated before please provide more detailed test instructions. How can a tester replicate the error etc
As stated before please provide more detailed test instructions. How can a tester replicate the error etc
Done!
I have tested this item ✅ successfully on f3bbd2d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43586.
@SniperSister Shouldn't it be fixed in 4.4-dev, too (or only there and later be merged up to 5.1-dev)? If it's a bug fix we should to it also in 4.4-dev, and if it's a new feature (what I don't think) it should to into 5.2-dev.
I have tested this item ✅ successfully on f3bbd2d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43586.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43586.
| Labels |
Added:
RTC
|
||
| Category | Front End Templates (site) | ⇒ | Administration Language & Strings Installation Libraries NPM Change Front End Templates (site) Unit Tests Repository JavaScript |
Shouldn't it be fixed in 4.4-dev, too (or only there and later be merged up to 5.1-dev)?
@richard67 fair comment. I have rebased the PR as suggested!
| Title |
|
||||||
| Category | Front End Templates (site) Administration Language & Strings Installation Libraries NPM Change Unit Tests Repository JavaScript | ⇒ | Front End Templates (site) |
| Labels |
Added:
Language Change
PR-4.4-dev
Removed: PR-5.1-dev |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-06-14 17:52:49 |
| Closed_By | ⇒ | MacJoom | |
| Labels |
Removed:
Language Change
|
||
Thank you!
Please provide more test instructions and what is expected to be seen in the generated source
Maybe I am looking at this wrong but before this PR I see
<link href="/media/templates/site/cassiopeia/css/global/fonts-local_roboto.min.css?8eef51" rel="stylesheet" media="all" onload="this.media='all'">With the PR applied I see
<link href="/media/templates/site/cassiopeia/css/global/fonts-local_roboto.min.css?447e02" rel="stylesheet" media="all" onload="this.media='all'">