[#43582] - [5.1] Remove the obsolete view and component metadata.xml manifest file
- Closed
- 31 May 2024
- Medium
- Build: 5.1-dev
- # 43582
- Diff
- sousa9g:5.1-dev-metadata-xml-removal
User tests: Successful: Unsuccessful:
Summary of Changes
This pull request removes the usage of view and component manifest file metadata.xml in com_menus. At this moment there is no usage of view and component metadata.xml in the core as the core only uses layout based manifest file for menu items.
View and component metadata.xml was made optional since 2015: #7654
Until now I am not aware of any Joomla 3rd extensions that use view and component metadata.xml for menu items. Please correct me if I am wrong.
Removing it to simplify the code base and make the menu item creation faster (in milliseconds maybe).
Testing Instructions
- /administrator/index.php?option=com_menus&view=items: should work normally
- New menu item creation should work normally
- The menu item types list should work normally (the list opened in modal window)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
Applying this PR will break several extensions. I did a quick grep of my server and found several extensions that use this.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-31 12:10:23 |
| Closed_By | ⇒ | Fedik | |
| Labels |
Added:
PR-5.1-dev
|
||
metadata.xml is not obsolete, and used across different components still, very much.
I use it in some of my components, as it only one way to add custom view without view layouts.
I closing it. Thanks.
You cannot just remove something. It must be deprecated first. Just because you don't know if anyone using it doesn't mean it's not being used.