RTC Language Change PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
30 May 2024

Pull Request for Issue #43548 alternative to #43570 .

This pr is an alternative to #43570 and used as inspiration.

Summary of Changes

Add item position and total count to Page Navigation

image

The total and the current item position will be present on any list view that uses pagination->getListFooter(); ?>

Testing Instructions

Go to the backend and check list views.

Actual result BEFORE applying this Pull Request

No Line like shown in the image

Expected result AFTER applying this Pull Request

An additional line with some basic information of the position and total amount of the list view.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org: Screenshots might needs to be updated

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: Additonal parameter for the layout

  • No documentation changes for manual.joomla.org needed

avatar HLeithner HLeithner - open - 30 May 2024
avatar HLeithner HLeithner - change - 30 May 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2024
Category Administration Language & Strings Layout
avatar HLeithner HLeithner - change - 30 May 2024
Labels Added: Language Change PR-5.2-dev
avatar brianteeman
brianteeman - comment - 30 May 2024

I closed my PR in favour of this one. It does more than was requested but that's a good thing.

NOTE:
Note that both this implementation and the alternative are not completely correct when it comes to accessibility. The information should really be in the caption element

avatar chmst
chmst - comment - 30 May 2024

I like this feature, tested and it works perfectly.

What do you think about using a badge?
grafik

@brianteeman I first had the same thought as you but cannot find a rule which requires presenting the information in the caption. Do you have a link?

avatar brianteeman
brianteeman - comment - 30 May 2024

A table caption is intended to describe a table - if we include how the table is sorted and filtered in that description (we do) then by the same toke we should include how many items are in the table.

avatar brianteeman brianteeman - test_item - 1 Jun 2024 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Jun 2024

I have tested this item ✅ successfully on d7794ad

Better to have it and it not be perfect for accessibility than not have it at all.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43575.

avatar alikon alikon - test_item - 2 Jun 2024 - Tested successfully
avatar alikon
alikon - comment - 2 Jun 2024

I have tested this item ✅ successfully on d7794ad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43575.

avatar alikon alikon - change - 2 Jun 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 2 Jun 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43575.

avatar pe7er pe7er - close - 3 Jun 2024
avatar pe7er pe7er - merge - 3 Jun 2024
avatar pe7er pe7er - change - 3 Jun 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-06-03 09:48:36
Closed_By pe7er
Labels Added: RTC
avatar pe7er
pe7er - comment - 3 Jun 2024

Thank you @brianteeman and @HLeithner for coding this feature!

Add a Comment

Login with GitHub to post a comment