No Code Attached Yet
avatar tkuschel
tkuschel
30 May 2024

Joomla 5.1.1 package,
the file media/com_media/js/media-manager.js has mixed line endings inside the file.
See https://developer.joomla.org/coding-standards/basic-guidelines.html

Steps to reproduce the issue

Several options:

  1. You can either view the the line endings <LF>, <CR><LF> with $, ^M$ : cat -e media-manager.js

  2. Or with dos2unix -n media-manager.js media-manager-lf.js

    diff -uN media-manager.js media-manager-lf.js > diff.txt

Expected result

Be Unix formatted. Lines must end only with a line feed (LF).

Actual result

Mixed line endings.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar tkuschel tkuschel - open - 30 May 2024
avatar tkuschel tkuschel - change - 30 May 2024
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2024
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 30 May 2024
avatar tkuschel tkuschel - change - 30 May 2024
Title
/media/com_media/js/media-manager.js mixed line endings CR CR/LF
/media/com_media/js/media-manager.js mixed line endings LF CR/LF
avatar tkuschel tkuschel - edited - 30 May 2024
avatar tkuschel
tkuschel - comment - 30 May 2024

Also the same issue in Joomla 5.2.0-alpha1-Alpha-Full_Package.zip

avatar tkuschel
tkuschel - comment - 2 Jun 2024

I've seen, the inside mixing up with different line endings sources from npm installation of vuex-persist, I already put an issue to championswimmer/vuex-persist#269

Maybe we can remove line endings CRLF to LF during npm installation of external modules... I will investigate to look about it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43573.
avatar tkuschel
tkuschel - comment - 2 Jun 2024

see above

avatar tkuschel tkuschel - change - 2 Jun 2024
Status New Closed
Closed_Date 0000-00-00 00:00:00 2024-06-02 09:12:17
Closed_By tkuschel
avatar tkuschel tkuschel - close - 2 Jun 2024

Add a Comment

Login with GitHub to post a comment