Language Change PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 May 2024

Pull Request for Issue ##43548 .

Summary of Changes

Adds the total number of items at the end of a table

image

The total will be present on any list view that uses <?php echo $this->pagination->getListFooter(); ?>

Testing Instructions

Apply PR and check the bottom of the table
Make sure that the total is correct after filters have been applied
Make sure that the total is displayed even when the pagination is not applied

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 29 May 2024
avatar brianteeman brianteeman - change - 29 May 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2024
Category Administration Language & Strings Layout
avatar HLeithner
HLeithner - comment - 30 May 2024

if you already introduce a new line, wouldn't it make sense to also show the current item position something like:
1 - 20 / 60 items

Language string would be something like this:

JLIB_HTML_PAGINATION_ITEMS="%1$d - %2$d / %3$d items"

avatar brianteeman
brianteeman - comment - 30 May 2024

That was not part of the feature request

2e4a741 30 May 2024 avatar brianteeman cs
avatar brianteeman brianteeman - change - 30 May 2024
Labels Added: Language Change PR-5.2-dev
avatar HLeithner
HLeithner - comment - 30 May 2024

You are right I created an alternative implementation #43575

avatar brianteeman
brianteeman - comment - 30 May 2024

Note that both this implementation and the alternative are not completely correct when it comes to accessibility. The information should really be in the caption element

avatar brianteeman brianteeman - change - 30 May 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-05-30 20:22:18
Closed_By brianteeman
avatar brianteeman
brianteeman - comment - 30 May 2024

Closing this in favour of #43575

avatar brianteeman brianteeman - close - 30 May 2024
avatar pe7er
pe7er - comment - 3 Jun 2024

Thanks @brianteeman !

Add a Comment

Login with GitHub to post a comment