[#43562] - [5.1] Reset the cached layout data during FormField setup()
- Fixed in Code Base
- 3 Jul 2024
- Medium
- Build: 5.1-dev
- # 43562
- Diff
- sousa9g:patch-1
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Joomla 5.1 added a new method to cache the form field layout data (collectLayoutData()). While it is great for performance, it is now impossible to reset the cached layout data.
In the FormField setup(). The input and labels are cleared:
$this->input = null;
$this->label = null;
However with the introductions of memory caching layout data, those lines don't work anymore, as the input is always rendered using the cached layout data.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
I have tested this item ✅ successfully on fd1f6c5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43562.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43562.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-03 14:08:38 |
| Closed_By | ⇒ | LadySolveig |
Thank you @sousa9g ? and also for review and testing @Fedik and @viocassel ?
I have tested this item ✅ successfully on fd1f6c5
On review. It doing the same as $this->input = null; $this->label = null;
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43562.