? Success

User tests: Successful: Unsuccessful:

avatar pjmatos
pjmatos
26 Sep 2014

When an email link parameter contains values with characters such as #, ( or ), among others -
< a href="mailto:email @ ..." style="color: #00F">email @ ...< /a>

only the latter pattern in the _clock function is matched and thus the code becomes broken.

avatar pjmatos pjmatos - open - 26 Sep 2014
avatar jissues-bot jissues-bot - change - 26 Sep 2014
Labels Added: ?
avatar pjmatos pjmatos - change - 26 Sep 2014
Title
Fix: Email cloak broken when link parameters are not parsed
Email cloak broken when link parameters are not parsed
avatar pjmatos pjmatos - change - 26 Sep 2014
The description was changed
Title
Fix: Email cloak broken when link parameters are not parsed
Email cloak broken when link parameters are not parsed
avatar pjmatos pjmatos - change - 26 Sep 2014
The description was changed
avatar zero-24 zero-24 - change - 26 Sep 2014
Category Front End Plugins
avatar infograf768
infograf768 - comment - 26 Sep 2014

@test
Works fine here. No unwanted consequences on other types of styling.
We need also a backport for 2.5.x

avatar pjmatos
pjmatos - comment - 26 Sep 2014

Thanks, done #4356

avatar mbabker
mbabker - comment - 29 Sep 2014

Test:

Created an article with content <p>E-mail me at <a style="color: #00f;" href="mailto:michael.babker@joomla.org">michael.babker@joomla.org</a></p> and this screenshot shows the result pre-patch:
screen shot 2014-09-29 at 09 51 59

Applied patch and got the following result:
screen shot 2014-09-29 at 09 52 58

Looked at the HTML source code for each, seems like the expected result is returned here.

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar mbabker mbabker - test_item - 29 Sep 2014 - Tested successfully
avatar mbabker mbabker - alter_testresult - 29 Sep 2014 - infograf768: Tested successfully
avatar mbabker mbabker - change - 29 Sep 2014
Milestone Added:
avatar mbabker mbabker - close - 29 Sep 2014
avatar mbabker mbabker - close - 29 Sep 2014
avatar mbabker mbabker - change - 29 Sep 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-09-29 14:55:58
avatar mbabker mbabker - reference | 2b3469f - 29 Sep 14
avatar mbabker mbabker - change - 29 Sep 2014
Status Closed Fixed in Code Base
avatar piotr-cz piotr-cz - reference | f1f79bc - 6 Oct 14
avatar Sophist-UK Sophist-UK - reference | 30e4a95 - 7 Oct 14
avatar dgt41 dgt41 - reference | 0956351 - 13 Oct 14
avatar rdeutz rdeutz - reference | 10c66c7 - 24 Oct 14

Add a Comment

Login with GitHub to post a comment