RTC PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
24 May 2024

Pull Request for Issue #43511 .

Summary of Changes

When you have a custom field set to be indexed in Smart Search and run that indexing process in the CLI, it will fail because the CLI process doesn't have a user object. The failure happens in the HTMLHelper::date() method and this PR simply checks if there is a user object to get the timezone from.

Testing Instructions

  1. Create a custom field of type calendar for your articles and set it to be indexed by Smart Search
  2. Run php cli/joomla.php finder:index on the command line

Actual result BEFORE applying this Pull Request

Fatal error in HTMLHelper::date()

Expected result AFTER applying this Pull Request

Indexing works as expected.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 24 May 2024
avatar Hackwar Hackwar - change - 24 May 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2024
Category Libraries
avatar ceford ceford - test_item - 24 May 2024 - Tested successfully
avatar ceford
ceford - comment - 24 May 2024

I have tested this item ✅ successfully on b031b01


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43521.

avatar viocassel viocassel - test_item - 24 May 2024 - Tested successfully
avatar viocassel
viocassel - comment - 24 May 2024

I have tested this item ✅ successfully on b031b01


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43521.

avatar Quy Quy - change - 24 May 2024
Status Pending Ready to Commit
Labels Added: PR-5.1-dev
avatar Quy
Quy - comment - 24 May 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43521.

avatar bembelimen bembelimen - close - 26 May 2024
avatar bembelimen bembelimen - merge - 26 May 2024
avatar bembelimen bembelimen - change - 26 May 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-05-26 21:56:20
Closed_By bembelimen
Labels Added: RTC
avatar bembelimen
bembelimen - comment - 26 May 2024

Thx

Add a Comment

Login with GitHub to post a comment