Feeling Lucky
PR-6.0-dev
[#43517] - [6.0] Replacing getDbo() with call to container
- Closed
- 14 Aug 2024
- Medium
- Build: 5.2-dev
- # 43517
- Diff
- Hackwar:5.2-database-container
User tests: Successful: Unsuccessful:
Summary of Changes
The call to Factory::getDbo() is deprecated. This PR replaces that with calls to the DI container.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_associations com_banners com_categories com_config com_contact com_content com_contenthistory com_fields com_finder com_installer com_languages com_login com_menus com_modules com_newsfeeds com_plugins com_redirect com_templates |
| Labels |
Added:
PR-5.2-dev
|
||
HLeithner
- comment
- 16 Jul 2024
As already discussed, this is not a solution it only fixes the syndrome (Deprecation warning). So for now I rebase this for 6.0 and hope that we don't need this pr and have a proper solution for all situations.
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-14 11:01:34 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
PR-6.0-dev
Removed: PR-5.2-dev |
||
laoneo
- comment
- 14 Aug 2024
I'm closing this as the target is to remove the static calls at all.
@Hackwar I think unit tests are failing at places where the isMariaDb method of the MySQL drivers are used because this method is not part of the database interface.
Update: It seems unit tests are failing for a different reason. The
isMariaDbmethod we use only in fileinstallation/src/Helper/DatabaseHelper.php.