PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
22 May 2024

Summary of Changes

Toolbar::getInstance() has been deprecated for quite some time now, but the alternative wasn't really clear yet. This PR replaces all occurences with $this->getDocument()->getToolbar() instead. This leaves the Toolbar::getInstance() in the ToolbarHelper class.

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 22 May 2024
avatar Hackwar Hackwar - change - 22 May 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2024
Category Administration com_admin com_associations com_banners com_cache com_categories com_checkin com_config com_contact com_content com_cpanel com_fields com_finder
avatar HLeithner
HLeithner - comment - 22 May 2024

What the issue @brianteeman ?

avatar brianteeman
brianteeman - comment - 22 May 2024

What the issue @brianteeman ?

  1. obvious errors due to blindly search/replace (picked up by drone)
  2. stating that no documentation is required.
avatar Hackwar Hackwar - change - 23 May 2024
Labels Added: PR-5.2-dev

Add a Comment

Login with GitHub to post a comment