[#43512] - [5.2] Remove Toolbar::getInstance() from views
- Fixed in Code Base
- 14 Aug 2024
- Medium
- Build: 5.2-dev
- # 43512
- Diff
- Hackwar:5.2-toolbar
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Toolbar::getInstance() has been deprecated for quite some time now, but the alternative wasn't really clear yet. This PR replaces all occurences with $this->getDocument()->getToolbar() instead. This leaves the Toolbar::getInstance() in the ToolbarHelper class.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_associations com_banners com_cache com_categories com_checkin com_config com_contact com_content com_cpanel com_fields com_finder |
What the issue @brianteeman ?
- obvious errors due to blindly search/replace (picked up by drone)
- stating that no documentation is required.
| Labels |
Added:
PR-5.2-dev
|
||
I checked all files but can't find a search replace issue. if you mean the conversation from Toolbar::getInstance('toolbar'); to $this->getDocument()->getToolbar(); without the parameter toolbar this is ok because the default toolbar is toolbar.
on the side I checked some file for missing removal of the use statement for the toolbar which can be removed if not used, as it has been done for some view.
Sorry no idea as its been 10 weeks but based on my comment it must have been something shown up in drone so maybe retrigger drone and see
Done
Done
I flagged some. There are more to remove.
Done
I flagged some. There are more to remove.
No, I thoroughly went through them all at that time and all other instances are still in use.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-14 11:49:00 |
| Closed_By | ⇒ | laoneo |
Thanks!
What the issue @brianteeman ?