[#43475] - [5.2] Mail Templates language file loading not using the MailsHelper::loadTranslationFiles
- Fixed in Code Base
- 16 Jul 2024
- Medium
- Build: 5.1-dev
- Easy Test
- # 43475
- Diff
- zero-24:mail_loadlanguage_file
User tests: Successful: Unsuccessful:
Summary of Changes
Load the template language files via the MailsHelper over an manuall code which not handles it correctly for example for plugins.
Testing Instructions
- Install this extension: https://github.com/zero-24/plg_task_extensionupdates/releases
- check the mail templates (system -> Mail Templates -> Extensions Update Notification)
- notice that the mail template is not translated
- apply this patch
- notice the templates are now translated
- check other mail templates
- confirm they are also still translated
Actual result BEFORE applying this Pull Request
On the detail view an mail template shipped with an plugin is not translated
Expected result AFTER applying this Pull Request
Once that patch is applied the issue is solved
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Labels |
Added:
PR-5.1-dev
|
||
| Easy | No | ⇒ | Yes |
Yes sorry i have added it to my test Installation but not to the patch. Its added now, please try again. Thanks
I have tested this item ? unsuccessfully on c903f7c
The added line solved the error indeed.
But after applying the patch, the subject and bodytexts are only in English, even when i select the German flag for example.
This occurs to all mailtemplates, not only plg_task_extensionupdates
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43475.
Hmm need to look into this deeper later. When its happening with and without the patch it looks like a different issue.
I looks like the core templates work in the right language without the patch.
Without the patch your extension only shows English
Only when i move your languagefiles to the /administrator/language/de-DE folder it works for German too.
(I have the same issue with a plugin i'm developing right now, so i was hoping this was the solution. :) )
Can you see that the german language file is loaded when logged in as german in the language debug?
With the Patch disabled:
With the Patch enabled:
When i change the backend language to german, all mails switch to german (even en-GB as in this screenshot)
Ok so the issue i saw is solved now but the switch of language seams not to be respected not by the current nor by the new coding. That needs more debugging than how it should work and why it does not work right now. Thanks ?
@JeroenMoolenschot I think i have found the issue, please try again.
I have tested this item ✅ successfully on 423ec91
Thank you! This works for me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43475.
| Title |
|
||||||
| Category | Administration | ⇒ | Administration Language & Strings Installation Libraries NPM Change |
Moved to 5.2 looking forward to tests on this PR so it can be merged.
| Labels |
Added:
Language Change
NPM Resource Changed
PR-5.2-dev
|
||
| Category | Administration Language & Strings Installation Libraries NPM Change | ⇒ | Administration Libraries |
| Labels |
Removed:
Language Change
NPM Resource Changed
|
||
| Category | Administration Libraries | ⇒ | Administration |
| Labels |
Removed:
PR-5.1-dev
|
||
I have tested this item ✅ successfully on 53f137e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43475.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43475.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-16 15:44:58 |
| Closed_By | ⇒ | pe7er | |
| Labels |
Added:
RTC
|
||
Thanks ?
I have tested this item ? unsuccessfully on 3ccce67
After applying the patch i see:
An error has occurred.
0 Class "Joomla\Component\Mails\Administrator\View\Template\MailsHelper" not found
Seems like this line is missing.
use Joomla\Component\Mails\Administrator\Helper\MailsHelper;
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43475.