[#43468] - [5.1] Media manager thumbnails better try/catch
- Fixed in Code Base
- 16 May 2024
- Medium
- Build: 5.1-dev
- # 43468
- Diff
- dgrammatiko:patch-2
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The existing try/catch assumes that the class Image could be instantiated given a path. This might throw if avif or webp is not enabled in the GD (ie misconfigured PHP build).
The try/catch now will handle this in a more predictable way (won't break the media manager list view)
Testing Instructions
Code review, or just upload a new file (assume that the thumbs are enabled)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
@LadySolveig @bembelimen this PR is adjacent to #43295 (comment) so please consider merging it. Thanks
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
PR-5.1-dev
|
||
I have tested this item ✅ successfully on 07c04b2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43468.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43468.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-16 09:08:04 |
| Closed_By | ⇒ | bembelimen |
Thx
I have tested this item ✅ successfully on 07c04b2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43468.