User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This pull request (PR) updates the lists of files and folders to be deleted on update in file administrator/components/com_admin/script.php in the 5.1-dev branch in preparation for the upcoming 5.1.1 release.
All entries added to the lists are caused by the different handling of the composer dependency laminas/laminas-diactoros on the last 4.4.4 and 5.1.0 releases due to security patches:
cweagans/composer-patches was added, which patches the older version with the same security fixes as we would get with the latest version. See this commit: 92f2ffblaminas/laminas-diactoros was already up to date. It had been updated with 5.0.0 to version 2.24.0 which includes the security fixes which were patched in 4.4.4.Therefore the new composer dependency cweagans/composer-patches added to 4.4-dev is not needed in 5.1-dev, so this PR here removes it when updating a 4.4.4 or later to 5.1.1 or later, and it removes the patch information PATCHES.txt from the folder of the laminas/laminas-diactoros dependency which was created by the removed tool.
Code review, or if you want to do a real test:
Update the latest 4.4 nightly build to the latest 5.1 nightly build to get the actual result, and update latest 4.4 nightly build to the patched package created by Drone for this PR to get the expected result.
Here you can find the patched update package or custom update URL created by Drone for this PR: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43461/downloads/76100/
The files and folders added by this PR to file administrator/components/com_admin/script.php are still present after the update.
The files and folders added by this PR to file administrator/components/com_admin/script.php have been removed with the update.
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_admin |
| Title |
|
||||||
| Labels |
Added:
PR-5.1-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-14 08:26:34 |
| Closed_By | ⇒ | LadySolveig |
Thank you @richard67 !
@LadySolveig Not merged yet by purpose? Or just forgotten?