RTC Language Change PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
9 May 2024

Pull Request for Issue #43449 .

Summary of Changes

  1. Combine nested if
  2. add a class to the link to force it to be underlined

Testing Instructions

Enable any of the MFA methods and then try to print out the backup codes

Actual result BEFORE applying this Pull Request

chrome_3Ns56XJJ8c

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

c432910 9 May 2024 avatar brianteeman fix
avatar brianteeman brianteeman - open - 9 May 2024
avatar brianteeman brianteeman - change - 9 May 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2024
Category Administration com_users Language & Strings Front End
avatar brianteeman
brianteeman - comment - 9 May 2024

This is an option. Another would be to change it from a string and link to a button similar to
image

avatar richard67
richard67 - comment - 9 May 2024

@brianteeman Does this close the referred issue #43449 ?

avatar brianteeman
brianteeman - comment - 9 May 2024

it's an option

avatar dautrich dautrich - test_item - 12 May 2024 - Tested successfully
avatar dautrich
dautrich - comment - 12 May 2024

I have tested this item ✅ successfully on c432910


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43450.

avatar brianteeman brianteeman - change - 12 May 2024
Labels Added: Language Change PR-4.4-dev
avatar dautrich dautrich - test_item - 13 May 2024 - Tested successfully
avatar dautrich
dautrich - comment - 13 May 2024

I have tested this item ✅ successfully on 559d520


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43450.

avatar Quy Quy - test_item - 13 May 2024 - Tested successfully
avatar Quy
Quy - comment - 13 May 2024

I have tested this item ✅ successfully on 559d520


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43450.

avatar Quy Quy - change - 13 May 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 May 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43450.

avatar laoneo laoneo - change - 14 May 2024
Labels Added: RTC
avatar MacJoom MacJoom - close - 14 May 2024
avatar MacJoom MacJoom - merge - 14 May 2024
avatar MacJoom MacJoom - change - 14 May 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-05-14 11:44:34
Closed_By MacJoom
avatar MacJoom
MacJoom - comment - 14 May 2024

Thank you!

Add a Comment

Login with GitHub to post a comment