NPM Resource Changed PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
7 May 2024

Single line comments should begin with // followed by a space

This has zero effect on compiling the css. It is just for

  • consistency
  • easier to search for a comment without finding all the urls
  • some scss tools require the space
  • pedantic

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 7 May 2024
avatar brianteeman brianteeman - change - 7 May 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2024
Category Repository NPM Change
avatar brianteeman brianteeman - change - 7 May 2024
Labels Added: NPM Resource Changed PR-5.2-dev
avatar wilsonge
wilsonge - comment - 8 May 2024

LGTM and all whitespace changes now so merging on review.

avatar brianteeman
brianteeman - comment - 8 May 2024

thanks

avatar wilsonge wilsonge - change - 8 May 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-05-08 14:05:49
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 May 2024
avatar wilsonge wilsonge - merge - 8 May 2024

Add a Comment

Login with GitHub to post a comment