RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
6 May 2024

Summary of Changes

Deprecate use of DispatcherAware and LanguageAware within CMSPlugin class.

Plugin should use DispatcherAware it on its own.
And LanguageAware is a leftover from some changes in past, and does not used anywhere (I did not found).

Testing Instructions

Code review.
Navigate around the site.
Edit site content.
Use finder indexer.
All should work as before.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: joomla/Manual#419
  • No documentation changes for manual.joomla.org needed

Linked:

avatar Fedik Fedik - open - 6 May 2024
avatar Fedik Fedik - change - 6 May 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 May 2024
Category Libraries Front End Plugins
avatar Fedik Fedik - change - 6 May 2024
The description was changed
avatar Fedik Fedik - edited - 6 May 2024
avatar Fedik Fedik - change - 7 May 2024
Labels Added: Feature PR-5.2-dev
avatar Fedik Fedik - change - 7 May 2024
The description was changed
avatar Fedik Fedik - edited - 7 May 2024
avatar Fedik Fedik - change - 12 May 2024
The description was changed
avatar Fedik Fedik - edited - 12 May 2024
avatar Fedik Fedik - change - 12 May 2024
The description was changed
avatar Fedik Fedik - edited - 12 May 2024
avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
[5.2] CMSPlugin: Deprecate use of DispatcherAware and LanguageAware
[5.3] CMSPlugin: Deprecate use of DispatcherAware and LanguageAware
avatar HLeithner HLeithner - edited - 2 Sep 2024
avatar Fedik Fedik - change - 2 Sep 2024
Labels Added: PR-5.3-dev
avatar Fedik Fedik - change - 18 Jan 2025
The description was changed
avatar Fedik Fedik - edited - 18 Jan 2025
avatar softforge softforge - test_item - 22 Feb 2025 - Tested successfully
avatar softforge
softforge - comment - 22 Feb 2025

I have tested this item ✅ successfully on 32f8a00

All the things listed and more work as expected after applying


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43430.

avatar komalm komalm - test_item - 22 Feb 2025 - Tested successfully
avatar komalm
komalm - comment - 22 Feb 2025

I have tested this item ✅ successfully on 32f8a00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43430.

avatar alikon alikon - change - 22 Feb 2025
Status Pending Ready to Commit
avatar alikon
alikon - comment - 22 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43430.

avatar Fedik Fedik - change - 28 Feb 2025
Labels Added: RTC
Removed: Feature PR-5.2-dev
f38e2e8 28 Feb 2025 avatar Fedik cs
avatar rdeutz rdeutz - change - 28 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-28 16:54:40
Closed_By rdeutz
avatar rdeutz rdeutz - close - 28 Feb 2025
avatar rdeutz rdeutz - merge - 28 Feb 2025
avatar Fedik Fedik - change - 1 Mar 2025
The description was changed
avatar Fedik Fedik - edited - 1 Mar 2025
avatar HLeithner
HLeithner - comment - 4 Mar 2025

@rdeutz is something wrong with this pr or what's the reason that the corresponding manual pr has not been merged? Please revert the pr if it's wrong or merge the manual pr. thanks

avatar Fedik
Fedik - comment - 4 Mar 2025

the corresponding manual pr has not been merged?

I made it later, and forgot to ping @rdeutz
Sorry

Add a Comment

Login with GitHub to post a comment