[#43424] - Fixed: Consistency of "unpublished" -i con colours #43375
- Fixed in Code Base
- 30 Aug 2024
- Medium
- Build: 4.4-dev
- # 43424
- Diff
- mabdelaziz77:4.4-dev
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Fixed the inconsistency of the unpublished icon colour of the articles in the associations modal window.
Pull Request for Issue #43375 .
Summary of Changes
Changed the unpublished icon from icon-times (red) to icon-unpublish (grey) in the article associations modal window.
Testing Instructions
- Make sure the multi-language feature is enabled by enabling the System - Language Filter plugin.
- Install a second language if you have only one language installed.
- Create an article for each language, set their state to unpublished.
- Edit one of the two articles, go to the Associations tab and click the Select button to select an article.
- Make sure the unpublished icon is grey.
Actual result BEFORE applying this Pull Request
The unpublished icon color is red.
Expected result AFTER applying this Pull Request
The unpublished icon is grey.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
| Labels |
Added:
PR-4.4-dev
|
||
| Category | Administration com_content | ⇒ | Administration com_associations com_categories com_contact com_content com_fields com_modules com_newsfeeds |
There are more instances. Please find the following and apply the same change. Thank you!
0 => 'icon-times',
Replaced the other instances.
not that simple
you also need to change icon-folder to icon-archive
Also, please change icon-check to icon-publish.
I noticed that all the modal windows have the same issue. Is this look intentional?
I'm not sure if it’s supposed to be like this, so is there any reference we can check to see if this is the expected behavior?
Let me know!
@mabdelaziz77 thank you very much for your work!
Differences are not intentional, modal views should look same as the normal views. Probably testers forgot testing modal views in recent versions.
I have tested this item ✅ successfully on 7364302
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43424.
I have tested this item ✅ successfully on 7cb128d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43424.
I have tested this item ✅ successfully on 7cb128d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43424.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43424.
I have tested this item ✅ successfully on 7cb128d
I tested successfully both for articles and categories
- unpublished
- trashed
- archived
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43424.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-30 05:35:04 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
RTC
|
||
Thanks!
There are more instances. Please find the following and apply the same change. Thank you!
0 => 'icon-times',