? Success

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
25 Sep 2014

.

avatar bembelimen bembelimen - open - 25 Sep 2014
avatar jissues-bot jissues-bot - change - 25 Sep 2014
Labels Added: ?
avatar infograf768
infograf768 - comment - 25 Sep 2014

Please explain the reason behind this change as well as testing instructions.

avatar bembelimen
bembelimen - comment - 25 Sep 2014

Hello,

the only reason is, that the default language is always a star (*). So I thought, it's a good idea to set the star as default parameter. An example:

$id = 102; // any valid menu ID
$menu = JFactory::getApplication()->getMenu();
$menu->setDefault($id);
$default = $menu->getDefault();
print_r($default);

I think, this two methods should be compatible. (Test the code before and after the patch)

avatar brianteeman brianteeman - change - 26 Sep 2014
Category Multilanguage
avatar brianteeman brianteeman - change - 26 Sep 2014
The description was changed
avatar Hackwar
Hackwar - comment - 4 Jan 2015

@test This is a correct fix.

avatar Hackwar Hackwar - test_item - 4 Jan 2015 - Tested successfully
avatar jacxx
jacxx - comment - 4 Jan 2015

@Test, I have tested the fix and work. Jacxx :)

avatar wilsonge
wilsonge - comment - 5 Jan 2015

I can't imagine how setting the default home page item gets set outside of menu manager. But indeed it seems correct to use the same standardisation here as we have for the default value in com_menu's itself

avatar Hackwar
Hackwar - comment - 5 Jan 2015

There are several reasons to set the default home page. For example, I had to write a plugin that made a menu item the default page when the user first opened the page via some landing page. Remember that this is not set permanently, but only sets the default page in JMenu for the duration of the pageload.

avatar bembelimen
bembelimen - comment - 5 Jan 2015

Yep, I wrote a multi domain plugin (that's the reason why I found this "issue") where I set the default page depending on the domain.

avatar zero-24 zero-24 - alter_testresult - 5 Jan 2015 - jacxx: Tested successfully
avatar zero-24 zero-24 - change - 5 Jan 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 5 Jan 2015

moving to RTC since we have successdful tests by @Hackwar and @jacxx Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4342.

avatar wilsonge wilsonge - close - 6 Jan 2015
avatar wilsonge wilsonge - reference | 11504d0 - 6 Jan 15
avatar wilsonge wilsonge - merge - 6 Jan 2015
avatar wilsonge wilsonge - close - 6 Jan 2015
avatar wilsonge wilsonge - change - 6 Jan 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-01-06 01:02:03
avatar wilsonge
wilsonge - comment - 6 Jan 2015

Merged - thanks!

avatar wilsonge wilsonge - change - 6 Jan 2015
Milestone Added:
avatar bembelimen bembelimen - head_ref_deleted - 23 Jan 2015

Add a Comment

Login with GitHub to post a comment