[#43416] - [5.2] Update index.php - Installation template
- Fixed in Code Base
- 18 Jan 2025
- Medium
- Build: 5.2-dev
- # 43416
- Diff
- sinahaghparast:5.2-installation-template-webassetmanager
User tests: Successful: 0 Unsuccessful: 0
Pull Request for Issue # .
Summary of Changes
Streamlining a piece of code
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
For better code readability.
To comply with Fluent interface.
To manage the consumption of server resources, even if it is small.
That doesnt answer my question
Maybe I didn't understand the question well. Please ask another way.
With this change you are declaring that a script is dependent on other scripts that have not yet been declared.
My question is if that is ok or not.
| Labels |
Added:
PR-5.2-dev
|
||
I am so sorry. This was due to my carelessness.
Is that Ok now?
I have tested this item ✅ successfully on 66bdb1f
I see no errors after making the changes but there is an unnecessary blank line at 25 now the $this has been removed and the space above it no longer needed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43416.
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
bug
|
||
I have tested this item ✅ successfully on bf03c0d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43416.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43416.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-18 10:43:53 |
| Closed_By | ⇒ | Hackwar |
Thank you!
is it ok to declare a dependency before you use it.