PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar sinahaghparast
sinahaghparast
2 May 2024

Pull Request for Issue # .

Summary of Changes

Streamlining a piece of code

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar sinahaghparast sinahaghparast - open - 2 May 2024
avatar sinahaghparast sinahaghparast - change - 2 May 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2024
Category Installation
avatar brianteeman
brianteeman - comment - 2 May 2024

is it ok to declare a dependency before you use it.

avatar sinahaghparast
sinahaghparast - comment - 2 May 2024

For better code readability.
To comply with Fluent interface.
To manage the consumption of server resources, even if it is small.

avatar brianteeman
brianteeman - comment - 2 May 2024

That doesnt answer my question

avatar sinahaghparast
sinahaghparast - comment - 2 May 2024

Maybe I didn't understand the question well. Please ask another way.

avatar brianteeman
brianteeman - comment - 4 May 2024

With this change you are declaring that a script is dependent on other scripts that have not yet been declared.
image

My question is if that is ok or not.

avatar sinahaghparast sinahaghparast - change - 7 May 2024
Labels Added: PR-5.2-dev
avatar sinahaghparast
sinahaghparast - comment - 7 May 2024

I am so sorry. This was due to my carelessness.

Is that Ok now?

avatar softforge softforge - test_item - 24 Aug 2024 - Tested successfully
avatar softforge
softforge - comment - 24 Aug 2024

I have tested this item ✅ successfully on 66bdb1f

I see no errors after making the changes but there is an unnecessary blank line at 25 now the $this has been removed and the space above it no longer needed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43416.

avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
Update index.php - Installation template
[5.3] Update index.php - Installation template
avatar HLeithner HLeithner - edited - 2 Sep 2024
avatar Hackwar Hackwar - change - 3 Sep 2024
Title
[5.3] Update index.php - Installation template
[5.2] Update index.php - Installation template
avatar Hackwar Hackwar - edited - 3 Sep 2024

Add a Comment

Login with GitHub to post a comment