Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#43392] - [5.2] Add custom css

RTC PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
27 Apr 2024

Pull Request for Issue #41205 .

Summary of Changes

Checked if class is set and added it to the fields

Testing Instructions

copied from the issue

$options=array();
$o = new stdClass();
$o->value = 1;
$o->text = 'option 1';
$options[] = $o;

$attribs=array();
$attribs['class'] = 'MyCLass'
HTMLHelper::_('select.radiolist', $options, 'fieldname', $attribs);

Actual result BEFORE applying this Pull Request

<div class="controls">
  <div class="form-check form-check-inline">
    <input type="radio" class="form-check-input"  name="fieldname" id="fieldname1" value="1" class="MyCLass">
    <label for="fieldname1" class="form-check-label" id="fieldname1-lbl">option 1</label>
  </div>
</div>

class attribute is duplicated

Expected result AFTER applying this Pull Request

<div class="controls">
  <div class="form-check form-check-inline">
    <input type="radio" class="form-check-input MyCLass"  name="fieldname" id="fieldname1" value="1">
    <label for="fieldname1" class="form-check-label" id="fieldname1-lbl">option 1</label>
  </div>
</div>

Both the form-check-input and MyCLass should be merged in one class attribute

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar rdeutz rdeutz - open - 27 Apr 2024
avatar rdeutz rdeutz - change - 27 Apr 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Apr 2024
Category ⇒ Libraries
avatar rdeutz rdeutz - change - 27 Apr 2024
Labels Added: PR-5.2-dev
avatar rdeutz
rdeutz - comment - 28 Apr 2024

Thanks @richard67

avatar Quy Quy - test_item - 29 Apr 2024 - Tested successfully
avatar Quy
Quy - comment - 29 Apr 2024

I have tested this item ✅ successfully on 8932488

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43392.

avatar alikon alikon - test_item - 30 Apr 2024 - Tested successfully
avatar alikon
alikon - comment - 30 Apr 2024

I have tested this item ✅ successfully on 8932488

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43392.

avatar alikon alikon - change - 30 Apr 2024
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 30 Apr 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43392.

avatar Quy Quy - change - 1 May 2024
Labels Added: RTC
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2024
Category Libraries ⇒ Unit Tests Libraries
863daa2 2 May 2024 avatar rdeutz sign
avatar rdeutz rdeutz - change - 2 May 2024
Labels Added: Unit/System Tests
avatar rdeutz
rdeutz - comment - 2 May 2024

just for the record, I used this PR to pin the mysql service in our testing to 8.3.0 because it seems we have a problem with 8.4 and the integration tests

avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2024
Category Libraries Unit Tests ⇒ Libraries
avatar Quy Quy - change - 5 May 2024
Labels Removed: Unit/System Tests
avatar rdeutz rdeutz - change - 3 Jun 2024
Title
…
add custom css
[5.2] Add custom css
avatar rdeutz rdeutz - edited - 3 Jun 2024
avatar pe7er pe7er - close - 3 Jun 2024
avatar pe7er pe7er - merge - 3 Jun 2024
avatar pe7er pe7er - change - 3 Jun 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-06-03 10:11:06
Closed_By ⇒ pe7er

Add a Comment

Login with GitHub to post a comment