Unit/System Tests PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
27 Apr 2024

Pull Request for Issue #42528 .

Summary of Changes

Remove the at() function because it is deprecated for phpunit10.

Site note: Can be discussed if the test has make sense in the past, here I only made it run.

Testing Instructions

run the unit test e.g. phpunit --testdox --filter SessionManagerTest

Actual result BEFORE applying this Pull Request

deprecated messages for the test

Expected result AFTER applying this Pull Request

no deprecated messages for the test

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar rdeutz rdeutz - open - 27 Apr 2024
avatar rdeutz rdeutz - change - 27 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Apr 2024
Category Unit Tests
avatar brianteeman
brianteeman - comment - 27 Apr 2024

This does not resolve the reported issue. "phpunit it out of date and unsupported"

avatar rdeutz
rdeutz - comment - 27 Apr 2024

I want to do it in two steps, one to fix the test and when this is done update the phpunit version

avatar brianteeman
brianteeman - comment - 27 Apr 2024

thats perfect and expected but you shoujldnt have closed the issue until both are done

avatar wilsonge wilsonge - change - 7 May 2024
Labels Added: Unit/System Tests PR-5.2-dev
avatar wilsonge wilsonge - change - 7 May 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-05-07 22:20:08
Closed_By wilsonge
avatar wilsonge wilsonge - close - 7 May 2024
avatar wilsonge wilsonge - merge - 7 May 2024
avatar wilsonge
wilsonge - comment - 7 May 2024

Thanks!

Add a Comment

Login with GitHub to post a comment