[#43377] - InputFilter fails on cleaning string with HEX entities as string
- Fixed in Code Base
- 8 May 2024
- Medium
- Build: 4.4-dev
- # 43377
- Diff
- AlterBrains:patch-3
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
InputFilter::clean($string, 'string') fails when decoding the entities with HEX numbers
Testing Instructions
Execute the code:
$filter = \Joomla\CMS\Filter\InputFilter::getInstance();
var_dump($filter->clean('ÿ', 'string'));
die;Actual result BEFORE applying this Pull Request
See error chr(): Argument #1 ($codepoint) must be of type int, string given
Expected result AFTER applying this Pull Request
No errors.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-4.4-dev
|
||
I've restored @exlemor 's test result in the issue tracker so it's properly counted again. The commits which have invalidated the count were just clean branch updates.
It yields the answer of: string(2) "ÿ" so if that is expected - perfect.
@exlemor Yes, that character fits to the Unicode character given as hexadecimal number. See e.g. https://www.w3schools.com/charsets/tryit.asp?deci=255&ent=yuml .
I have tested this item ✅ successfully on 3d3e148
Works as described. In addition, I've tested that decimal values like 'ÿ' and entity names like 'ÿ' continue to work as before.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43377.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43377.
| Labels |
Added:
RTC
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-08 16:26:56 |
| Closed_By | ⇒ | MacJoom |
Thank you!
I have tested this item ✅ successfully on fee33cb
Hi AlterBrains, I have tested this successfully.
It yields the answer of: string(2) "ÿ" so if that is expected - perfect.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43377.