RTC PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar robertsilen
robertsilen
25 Apr 2024

Considering the technical requirements (https://manual.joomla.org/docs/next/get-started/technical-requirements/) include MariaDB, I humbly suggest the README.txt should include MariaDB too. I removed "SQL Server" from list of databases, as mentioned in another discussion (#43343). There is a separate PR for the .md version of the README.

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar robertsilen robertsilen - open - 25 Apr 2024
avatar robertsilen robertsilen - change - 25 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2024
Category Repository
avatar Quy
Quy - comment - 25 Apr 2024

Please combine your PRs into one under the v4.4 branch as it will be upmerged to v5.1. Thanks.

avatar robertsilen
robertsilen - comment - 25 Apr 2024

Please combine your PRs into one under the v4.4 branch as it will be upmerged to v5.1. Thanks.

I was told in PR for 4.4 to make a PR for 5.1 as this content is relevant for 5.1 and not 4.4. So I presume I should not go back on this?

Do you want me to merge this with the PR for README.md? Not sure how to do that.

avatar Quy
Quy - comment - 25 Apr 2024

I was told in PR for 4.4 to make a PR for 5.1 as this content is relevant for 5.1 and not 4.4. So I presume I should not go back on this?

Commented in the other PR.

Do you want me to merge this with the PR for README.md? Not sure how to do that.

Switch to patch-4 branch. Apply the change from the other branch.

avatar robertsilen robertsilen - change - 26 Apr 2024
Labels Added: PR-5.1-dev
avatar robertsilen robertsilen - change - 26 Apr 2024
Title
Update README.txt to include MariaDB (.txt, not .md)
Update README.txt to include MariaDB (.txt and .md)
avatar robertsilen robertsilen - edited - 26 Apr 2024
avatar robertsilen robertsilen - change - 26 Apr 2024
Title
Update README.txt to include MariaDB (.txt and .md)
Update README to include MariaDB (.txt and .md)
avatar robertsilen robertsilen - edited - 26 Apr 2024
avatar robertsilen robertsilen - change - 26 Apr 2024
Title
Update README to include MariaDB (.txt and .md)
Update to include MariaDB and remove SQL Server in README (.txt and .md)
avatar robertsilen robertsilen - edited - 26 Apr 2024
avatar robertsilen
robertsilen - comment - 26 Apr 2024

I was told in PR for 4.4 to make a PR for 5.1 as this content is relevant for 5.1 and not 4.4. So I presume I should not go back on this?

Commented in the other PR.

Do you want me to merge this with the PR for README.md? Not sure how to do that.

Switch to patch-4 branch. Apply the change from the other branch.

This PR for 5.5 includes MariaDB and SQL Server modifications to README.txt and README.md now. For 4.4 version there is this PR.

avatar Quy Quy - test_item - 7 May 2024 - Tested successfully
avatar Quy
Quy - comment - 7 May 2024

I have tested this item ✅ successfully on 1205699


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43368.

avatar viocassel viocassel - test_item - 17 May 2024 - Tested successfully
avatar viocassel
viocassel - comment - 17 May 2024

I have tested this item ✅ successfully on 1205699


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43368.

avatar Quy Quy - change - 17 May 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 17 May 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43368.

avatar Quy Quy - change - 17 May 2024
Labels Added: RTC
avatar LadySolveig LadySolveig - change - 20 May 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-05-20 12:16:18
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 20 May 2024
avatar LadySolveig LadySolveig - merge - 20 May 2024
avatar LadySolveig
LadySolveig - comment - 20 May 2024

Thank you @robertsilen and for review @Quy @viocassel

Add a Comment

Login with GitHub to post a comment