Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#43365] - [5.1] TinyMCE: can't insert media in article

No Code Attached Yet bug
avatar drmenzelit
drmenzelit
25 Apr 2024

Steps to reproduce the issue

In an article try to insert a PDF file (CMS Content -> Media)

Expected result

You can insert a link to or you get an iframe with the PDF

Actual result

Javascript error, insert button doesn't work for download PDF. Iframe seems to be inserted, after saving the article, the iframe dissapears

grafik

System information (as much as possible)

Joomla 5.1
PHP 8.1.28 / 8.2.18
MySQL 8.0.35 / MariaDB 10.6.15

Additional comments

avatar drmenzelit drmenzelit - open - 25 Apr 2024
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2024
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 25 Apr 2024
avatar brianteeman
brianteeman - comment - 25 Apr 2024

Confirm the error with the download
No problem with the insert, it produces an object which is saved without error
image

avatar Quy Quy - change - 25 Apr 2024
Labels Added: bug
avatar Quy Quy - labeled - 25 Apr 2024
avatar Fedik
Fedik - comment - 25 Apr 2024

This need to be relaced to editorInst.getSelection()

joomla-cms/build/media_source/system/js/fields/joomla-media-select.w-c.es6.js

Line 243 in fc51f46

} else if (Joomla.editors.instances[editor].getSelection() !== '') {

I will make PR, later

avatar Fedik Fedik - close - 26 Apr 2024
avatar Fedik
Fedik - comment - 26 Apr 2024

Please test #43374

avatar Fedik Fedik - change - 26 Apr 2024
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-04-26 10:15:47
Closed_By ⇒ Fedik
avatar drmenzelit drmenzelit - change - 27 Jun 2024
Status Closed ⇒ New
Closed_Date 2024-04-26 10:15:47 ⇒
Closed_By Fedik ⇒
avatar drmenzelit drmenzelit - reopen - 27 Jun 2024
avatar drmenzelit
drmenzelit - comment - 27 Jun 2024

The PR #43374 solved the problem with the PDF link, but not embedding the PDF. I can embed a file, but it doesn't display in the article, the PDF viewer is empty
grafik

avatar Quy Quy - change - 27 Jun 2024
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-06-27 22:28:42
Closed_By ⇒ Quy
avatar Quy Quy - close - 27 Jun 2024
avatar Quy
Quy - comment - 27 Jun 2024

Please test PR #43716. Thanks.

Add a Comment

Login with GitHub to post a comment