[#43353] - [4.4] Contact VCF: Properly assign value to array
- Fixed in Code Base
- 6 May 2024
- Medium
- Build: 4.4-dev
- # 43353
- Diff
- Hackwar:4.4-contact-vcf
User tests: Successful: Unsuccessful:
Summary of Changes
While going through the code with phpstan, this showed up as error. Instead of assigning the string to a new entry in the array, we are also trying to read from this array by trying to concatenate a string... I'm struggling to explain it, but if you look at the code, you see the problem. Right now this does not throw an error in PHP, but it is just a matter of time when PHP becomes strict enough to complain about this.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
| Labels |
Added:
PR-4.4-dev
|
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43353.
| Labels |
Added:
RTC
|
||
| Labels |
Added:
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-06 17:42:19 |
| Closed_By | ⇒ | MacJoom |
Thank you!
I have tested this item ✅ successfully on 59e7346
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43353.