[#43349] - [6.0] $this: Cleanup of typehints for phpstan
- Closed
- 3 Sep 2024
- Medium
- Build: 5.2-dev
- # 43349
- Diff
- Hackwar:5.2-phpstan-unknown
User tests: Successful: Unsuccessful:
Summary of Changes
When typehinting $this in our layouts, we use both the full qualified name and a shortened version with an import. phpstan unfortunately does not currently understand the version with the import and thus this unifies this to the long version.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_joomlaupdate com_users Front End Plugins |
| Labels |
Added:
PR-5.2-dev
|
||
Then we should disable the rule in phpstan, is there an issue to check at phpstan for this feature?
exactly
pe7er
- | Title |
|
||||||
Issue deferred to PHPStan, change not required in Joomla. Thanks Hannes.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-03 11:24:49 |
| Closed_By | ⇒ | Bodge-IT | |
| Labels |
Added:
Feature
PR-6.0-dev
Removed: PR-5.2-dev |
||
Is this excluded in our PHPStan setup?
no, it isn't.
Then we should disable the rule in phpstan, is there an issue to check at phpstan for this feature?