Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#43323] - [5.2] [PHP8.4] Update for nullable type declaration

Feature PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
20 Apr 2024

Summary of Changes

updates for https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

Testing Instructions

at the moment no QA release of PHP8.4 ... so only code review (and phpcs by drone) PHP 8.4.0 Alpha 1 available for testing

Actual result BEFORE applying this Pull Request

Warning:

Deprecated: Joomla\CMS\Application\AdministratorApplication::__construct(): Implicitly marking parameter $input as nullable is deprecated, the explicit nullable type must be used instead in libraries\src\Application\AdministratorApplication.php on line 74

Deprecated: Joomla\CMS\Application\AdministratorApplication::__construct(): Implicitly marking parameter $config as nullable is deprecated, the explicit nullable type must be used instead in libraries\src\Application\AdministratorApplication.php on line 74

Deprecated: Joomla\CMS\Application\AdministratorApplication::__construct(): Implicitly marking parameter $client as nullable is deprecated, the explicit nullable type must be used instead in libraries\src\Application\AdministratorApplication.php on line 74

Deprecated: Joomla\CMS\Application\AdministratorApplication::__construct(): Implicitly marking parameter $container as nullable is deprecated, the explicit nullable type must be used instead in libraries\src\Application\AdministratorApplication.php on line 74

[...]

Expected result AFTER applying this Pull Request

No new deprecated warnings (excepted composer dependencies) if update to PHP8.4

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
1740af6 20 Apr 2024 avatar heelc29 api
66e8d96 20 Apr 2024 avatar heelc29 tests
avatar heelc29 heelc29 - open - 20 Apr 2024
avatar heelc29 heelc29 - change - 20 Apr 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Apr 2024
Category ⇒ Administration com_associations com_banners com_categories com_checkin com_config com_contact com_content com_contenthistory com_fields
avatar heelc29 heelc29 - change - 20 Apr 2024
Labels Added: PR-5.1-dev
avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
…
[5.1][PHP8.4][WIP] Update for nullable type declaration
[5.2] [PHP8.4][WIP] Update for nullable type declaration
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar heelc29 heelc29 - change - 25 Apr 2024
Labels Added: Feature PR-5.2-dev
avatar heelc29 heelc29 - change - 25 Apr 2024
Title
…
[5.2] [PHP8.4][WIP] Update for nullable type declaration
[5.2] [PHP8.4] Update for nullable type declaration
avatar heelc29 heelc29 - edited - 25 Apr 2024
avatar heelc29 heelc29 - change - 12 Jul 2024
The description was changed
avatar heelc29 heelc29 - edited - 12 Jul 2024
avatar laoneo laoneo - change - 6 Aug 2024
Labels Removed: PR-5.1-dev
avatar laoneo laoneo - change - 6 Aug 2024
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-08-06 07:51:18
Closed_By ⇒ laoneo
avatar laoneo laoneo - close - 6 Aug 2024
avatar laoneo laoneo - merge - 6 Aug 2024
avatar laoneo
laoneo - comment - 6 Aug 2024

Thanks!

Add a Comment

Login with GitHub to post a comment