No Code Attached Yet
avatar nikitakothari06
nikitakothari06
18 Apr 2024

Steps to reproduce the issue

Execute administrator\components\com_admin\sql\updates\mysql\5.1.0-2024-02-24.sql file's query manually.

Expected result

Should not throw a syntax error.

Actual result

#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-----------------------------------------------------------
#__upd' at line 1

System information (as much as possible)

Joomla 5.0.1
PHP 8.1
Mysql 8.0

Additional comments

Line 27 comment should be in the following way.(space after two --) in administrator\components\com_admin\sql\updates\mysql\5.1.0-2024-02-24.sql file
"-- ---------------------------------------------------------"

avatar nikitakothari06 nikitakothari06 - open - 18 Apr 2024
avatar nikitakothari06 nikitakothari06 - change - 18 Apr 2024
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2024
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Apr 2024
avatar richard67
richard67 - comment - 18 Apr 2024

@nikitakothari06 Not really an issue as the updater doesn't execute the SQL script as such, but it splits it into the individual statements and executes each statement individually, so that syntax error will never happen with a Joomla update.

Nevertheless we can fix it of course.

avatar richard67 richard67 - change - 18 Apr 2024
Status New Closed
Closed_Date 0000-00-00 00:00:00 2024-04-18 17:00:50
Closed_By richard67
avatar richard67 richard67 - close - 18 Apr 2024
avatar richard67
richard67 - comment - 18 Apr 2024

Closing as having a pull request. Please test #43306 . When having tested, please go to the pull request in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43306 and use the blue "Test this" button at the top left corner, then sn select your test result and finally submit.

Thanks in advance.

Add a Comment

Login with GitHub to post a comment