User tests: Successful: Unsuccessful:
Unfortunately #3945 introduced a bug with pagination in com_content
category view (list and blog). As soon as you change the page, the pagination vanishes.
The reason is that we now also pass the limit
and offset
properties of the query object to the _getListCount
method. For some reason I couldn't tackle down yet, those are set in com_content
but not in other extensions like com_contact
or com_weblinks
.
However to get the count we should not use any limits anyway. It does make no sense to run a query SELECT COUNT(*) LIMIT 10, 20
. Thus we should be able to safely clear the limit part since we want an unlimited total list anyway.
Please test with various lists if this doesn't introduce yet another unexpected side effect...
Labels |
Added:
?
|
Category | ⇒ | Components |
I've tested the patch in category view (list and blog).
@test: successful. Patch is fixing the pagination issue.
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
@test
Able to reproduce (Cat List & Blog) then #4330 works as expected - Thanks
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
@Bakual Thanks for explanation. I can confirm that it is correct.
@test: Successful. This patch fixed the issue in the category
Also, from code review, it is correct to clear the limit clause. The reason is because the SELECT COUNT(*) query in this case will only return one record. So if we append LIMIT n, m to the query, it only works of n = 0. If n > 0 (when we navigate to the second page), the query will return an empty result (no record is returned) and that's the reason there is no pagination.
Hi,
Sorry for interrupting but can someone help me on how to test this "patch"? I may be a little noobish here and I really need to get my blog pagination back. Is there a file to download somewhere that I don't see or a code to modify in a Joomla core file?
I might need a little detailed help here please.
Thanks in advance for your precious help and sorry again if I'm barging in.
Denis.
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
Very easy - See http://docs.joomla.org/Component_Patchtester_for_Testers
Once you have installed the component as described there you can use it to
apply this patch.
On 24 September 2014 18:18, DenisLan notifications@github.com wrote:
Hi,
Sorry for interrupting but can someone help me on how to test this
"patch"? I may be a little noobish here and I really need to get my blog
pagination back. Is there a file to download somewhere that I don't see or
a code to modify in a Joomla core file?I might need a little detailed help here please.
Thanks in advance for your precious help and sorry again if I'm barging in.
Denis.
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
http://issues.joomla.org/http://issues.joomla.org/
http://issues.joomla.org/.—
Reply to this email directly or view it on GitHub
#4330 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Aaaah! Thank your very much Brian! And I confirm, the patch works on my side! :)
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
Since we have several good tests I'm setting this PR to RTC
Labels |
Added:
?
|
Status | Pending | ⇒ | Ready to Commit |
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-09-25 05:19:04 |
I confirm that it works, but problems with navigation Kunena 3.0.6, the Kunena team is warned http://www.kunena.org/forum/kunena-3-0-support/131741-problem-to-install-kunena-on-latest-joomla-version-3-3-4#159318
Actually you can do by entering the number of the PR in the search box ;)
On 27 September 2014 12:31, Cyril Rezé notifications@github.com wrote:
@test https://github.com/test ok
But, as the PR is closed, not possible to install it using
com_patchtester... :-(—
Reply to this email directly or view it on GitHub
#4330 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Brian, you're a King!!!
It works!
I found out the hard way ;)
On 27 September 2014 12:33, Cyril Rezé notifications@github.com wrote:
Brian, you're a King!!! [image: ]
It works!—
Reply to this email directly or view it on GitHub
#4330 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Hi, I tried this patch and received this error -
Not Found
Fatal error: Class 'JModelLegacy' not found in /home/african/public_html/administrator/components/com_k2/models/model.php on line 17
Umm, I would have no clue why this would try to instantiate the JModelLegacy class. Are you sure you applied this patch?
Hi, I tried to apply the patch too. Now I get a blank frontend and backend. Setting error reporting to maximum I get:
Fatal error: Class 'JModelLegacy' not found in /var/www/vhosts/xxx.eu/xxx/administrator/components/com_k2/models/model.php on line 17
Labels |
Removed:
?
|
@test issue confirmed as originally reported. Patch applied and issue resolved - thanks
This comment was created with the J!Tracker Application at http://issues.joomla.org/.