[#43270] - [5.1.0-rc2] Image Private Messages
- Closed
- 8 Aug 2024
- Medium
- Build: 4.4-dev
- # 43270
Steps to reproduce the issue
- Create 2 different user, both with "Receive System Emails" enabled.
- Form one user send a Private Message to the other
- Insert an image in the message body (eg.
https://<your joomla>/images/sampledata/cassiopeia/nasa1-1200.jpg):
- Send the message
- Check your inbox mail
- Logout and login thi the oter user
- Check your Private Messages
Expected result
- Mail have the image
- Private Messages must have the image
Actual result
- Mais haven't the image:
- your Private Messages have the wrong image url
System information (as much as possible)
Joomla 5.1.0-rc2
Additional comments
The image url does not have the initial /
If the URL begins without a slash, it will be relative to the current page. Example: src="img_girl. jpg". If the URL begins with a slash, it will be relative to the domain.
@brianteeman It could be related to PR #42448 ?
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
Ok, is different bug :(
This is not a bug of the Messaging component but a feature provided by the TinyMCE editor to convert absolute URLs to relative URLs.
To "fix" this issue, go to "System" - "Plugins" - "Editor TinyMCE" and set the option URLs to Absolute:
Sorry but that is not correct for this. Making that change will change it everywhere not just in private messages.
Yes, you are right. I explained the reason for this behaviour.
We need to apply the same logic for such relative URLs as we do in the SEF plugin (add the base path if required - \Joomla\Plugin\System\Sef\Extension\Sef::onAfterRender).
The correct way to address this is in the messaging component where the editor is rendered. Too late for me to write tested and working code but it would be something like
$params = ['relative_urls' => 'true']
$content = $editor->display($name, $content , $width, $height, $col, $row, true, $id, null, null, $params);
Actually we have to apply the logic of the SEF plugin partially to the output. Setting this option for tinymce will break the moment people use a different editor. Basically we have to copy the code to make the URLs absolute from the SEF plugin to the output of the message. Any takers?
Quy
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-08 16:01:29 |
| Closed_By | ⇒ | Quy |
#42448 was about adding images etc to the mail TEMPLATE so that you can do some branding
What you are talking about here is adding an image to the private message. Different thing