Feature PR-5.2-dev Code Review Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
12 Apr 2024

Summary of Changes

This PR removes almost all cases where we are accessing attributes of the user object through the deprecated CMSObject::get() method. All these can be replaced by simply accessing the attribute directly. This change is based on a check with phpstan.

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 12 Apr 2024
avatar Hackwar Hackwar - change - 12 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2024
Category Administration com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer com_menus com_messages com_modules com_newsfeeds
avatar sandewt sandewt - test_item - 15 Apr 2024 - Tested successfully
avatar sandewt
sandewt - comment - 15 Apr 2024

I have tested this item ✅ successfully on eefbe1a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43268.

avatar Hackwar Hackwar - change - 24 Apr 2024
Labels Added: Feature PR-5.2-dev Code Review
avatar pe7er pe7er - close - 30 Apr 2024
avatar pe7er pe7er - merge - 30 Apr 2024
avatar pe7er pe7er - change - 30 Apr 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-04-30 07:22:12
Closed_By pe7er
avatar pe7er
pe7er - comment - 30 Apr 2024

Thanks @Hackwar !

Add a Comment

Login with GitHub to post a comment