Feeling Lucky
Feature
PR-5.2-dev
Code Review
[#43265] - [5.2] Fixing typehint for getListQuery to QueryInterface
- Fixed in Code Base
- 30 Apr 2024
- Medium
- Build: 5.2-dev
- # 43265
- Diff
- Hackwar:5.2-getListQuery-QueryInterface
User tests: Successful: Unsuccessful:
Summary of Changes
The database object in Joomla returns an object implementing QueryInterface, but all our docblocks for getListQuery claim it is a DatabaseQuery object. This PR unifies this to use the QueryInterface everywhere. This set of changes is the result of a run of phpstan on our codebase.
Testing Instructions
Codereview.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_banners com_categories com_contact com_content com_contenthistory com_fields com_finder com_installer com_languages com_menus com_messages com_modules |
| Labels |
Added:
PR-5.2-dev
|
||
| Labels |
Added:
Feature
Code Review
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-30 13:53:01 |
| Closed_By | ⇒ | pe7er |
Thanks @Hackwar !